You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/07/27 02:13:52 UTC
[GitHub] brodybits commented on issue #284: [WIP] CB-14224 add license text
& GitHub link to template/Properties/Default.rd.xml - proposal (for
discussion)
brodybits commented on issue #284: [WIP] CB-14224 add license text & GitHub link to template/Properties/Default.rd.xml - proposal (for discussion)
URL: https://github.com/apache/cordova-windows/pull/284#issuecomment-408290387
Thanks for the quick review. I am afraid that I don't really understand
your question. I think this piece of XML was intended as some kind of
optional instructions.
On Thu, Jul 26, 2018, 9:24 PM Shazron Abdullah <no...@github.com>
wrote:
> *@shazron* commented on this pull request.
> ------------------------------
>
> In template/Properties/Default.rd.xml
> <https://github.com/apache/cordova-windows/pull/284#discussion_r205645861>
> :
>
> > @@ -13,6 +13,28 @@
>
> Using the Namespace directive to apply reflection policy to all the types in a particular namespace
> <Namespace Name="DataClasses.ViewModels" Seralize="All" />
> +
>
> Is this missing the start of the xml comment block?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/cordova-windows/pull/284#pullrequestreview-140960020>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABfNULbAJNGavRKlCYRaM5DBeMPegsT4ks5uKmvdgaJpZM4ViuSw>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org