You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "atikulmunna (via GitHub)" <gi...@apache.org> on 2026/08/01 12:04:27 UTC

Re: [PR] Check GCSToS3Operator match_glob support after template rendering [airflow]

atikulmunna commented on PR #70723:
URL: https://github.com/apache/airflow/pull/70723#issuecomment-5151339509

   Both fixed in 3c8d638003 plus a description rewrite.
   
   Test: you're right, it wasn't testing the polarity at all. The truthy glob would have passed the old condition too, so the `ValueError` swap was doing all the work. Parametrised over the glob and the empty string as suggested. `match_glob=""` is the case that separates the two conditions. Both pass, file is at 32.
   
   Description: it was still describing the first revision, including the bit about not being able to run the tests locally. Rewritten to match the diff, with a note that the earlier `execute()` version was corrected in review.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org