You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/07/13 17:35:05 UTC

[GitHub] [incubator-pinot] tmwangi opened a new issue #5692: Decouple pinot-tools dependency on pinot-server, pinot-controller and pinot-broker

tmwangi opened a new issue #5692:
URL: https://github.com/apache/incubator-pinot/issues/5692


   It would be a great idea to break this dependency by introducing some api modules or some other way. The result would be a smaller pinot-tools with none of the vulnerabilities or license issues that come with including the server, controller or broker. See https://github.com/apache/incubator-pinot/blob/master/pinot-tools/pom.xml for the dependencies included.
   
   For example in order to get the Pinot Table Creation url, I have to access the class https://github.com/apache/incubator-pinot/blob/47ff09b4c5d726355a4516d2e1eb72c9705b81b9/pinot-controller/src/main/java/org/apache/pinot/controller/helix/ControllerRequestURLBuilder.java which defines the url and is in the pinot-controller module. This could be defined in a much smaller pinot-controller-client or pinot-controller-api to avoid having to include all of pinot controller.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] tmwangi edited a comment on issue #5692: Decouple pinot-tools dependency on pinot-server, pinot-controller and pinot-broker

Posted by GitBox <gi...@apache.org>.
tmwangi edited a comment on issue #5692:
URL: https://github.com/apache/incubator-pinot/issues/5692#issuecomment-657758389


   Thanks @Jackie-Jiang . Our use case has to do with creating Pinot Tables and I think that part of Pinot Tools can be carved out into a module of its own as the dependencies on controller, server and broker are not needed for this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] tmwangi commented on issue #5692: Decouple pinot-tools dependency on pinot-server, pinot-controller and pinot-broker

Posted by GitBox <gi...@apache.org>.
tmwangi commented on issue #5692:
URL: https://github.com/apache/incubator-pinot/issues/5692#issuecomment-657758389


   Thanks @Jackie-Jiang 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5692: Decouple pinot-tools dependency on pinot-server, pinot-controller and pinot-broker

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #5692:
URL: https://github.com/apache/incubator-pinot/issues/5692#issuecomment-657747108


   Thanks for the suggestion.
   It is not possible to remove pinot-controller/broker/server dependency from pinot-tools because the tools package need to support starting controller/broker/server instance. But it is a great idea to add a separate client api module for admin purpose and have minimal dependencies.
   We are planning to re-organize `pinot-common` and `pinot-core` and split them into api/spi modules and implementation modules. Will add another client api module when we design the new package hierarchy.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org