[GitHub] khos2ow commented on a change in pull request #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+

[GitBox <gi...@apache.org>]

khos2ow commented on a change in pull request #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+
URL: https://github.com/apache/cloudstack/pull/2365#discussion_r158536765
 
 

 ##########
 File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/discoverer/XcpServerDiscoverer.java
 ##########
 @@ -529,13 +540,12 @@ public boolean processCommands(long agentId, long seq, Command[] commands) {
     }
 
     private void createXsToolsISO() {
-        String isoName = "xs-tools.iso";
-        VMTemplateVO tmplt = _tmpltDao.findByTemplateName(isoName);
+        VMTemplateVO tmplt = _tmpltDao.findByTemplateName(_toolsIsoName);
 
 Review comment:
   The problem is at this line `_toolsIsoName` is not initialized yet (basically `cretaeXsToolsISO` is executed before newly added `determineToolsIsoName` method). My other idea is at this line we can register both `xs-tools.iso` and `guest-tools.iso` and either:
   - later on (for example in `createServerResource` method) delete/deactivate the _wrong_ iso 
   - present both of them on UI with different names and let the user select the _correct_ iso based on the version of their Xen
   
   @rhtyd @wido @syed @rafaelweingartner @swill any comment, suggestion, concern?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services