You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@fluo.apache.org by Kenneth Mcfarland <ke...@apache.org> on 2018/01/18 07:00:38 UTC
#991 format source
This is a kind reminder to all devs pls run mvn verify to ensure the
patches are formatted.
When you run mvn verify it will format all of the source code which will
create changes.
If you commit and then run mvn verify and it formats something then you
have another commit to issue. IMHO It is best to run mvn verify and then if
everything passes issue a commit, or squash, or whatever works for you.
Happy coding!
Re: #991 format source
Posted by Christopher <ct...@apache.org>.
The plugin has a goal for validating config:
http://code.revelc.net/formatter-maven-plugin/validate-mojo.html
We're not using it, because it's a bit redundant, but it might make sense
to add it in a profile which is used during releases and in CI builds.
On Thu, Jan 18, 2018 at 4:09 PM Keith Turner <ke...@deenlo.com> wrote:
> On Thu, Jan 18, 2018 at 2:00 AM, Kenneth Mcfarland
> <ke...@apache.org> wrote:
> > This is a kind reminder to all devs pls run mvn verify to ensure the
> > patches are formatted.
>
> Ideally the travis build would fail if it formatted code. This may be
> possible if there is a maven plugin that checks if any git tracked
> files were changed.
>
> >
> > When you run mvn verify it will format all of the source code which will
> > create changes.
> >
> > If you commit and then run mvn verify and it formats something then you
> > have another commit to issue. IMHO It is best to run mvn verify and then
> if
> > everything passes issue a commit, or squash, or whatever works for you.
> >
> > Happy coding!
>
Re: #991 format source
Posted by Keith Turner <ke...@deenlo.com>.
On Thu, Jan 18, 2018 at 2:00 AM, Kenneth Mcfarland
<ke...@apache.org> wrote:
> This is a kind reminder to all devs pls run mvn verify to ensure the
> patches are formatted.
Ideally the travis build would fail if it formatted code. This may be
possible if there is a maven plugin that checks if any git tracked
files were changed.
>
> When you run mvn verify it will format all of the source code which will
> create changes.
>
> If you commit and then run mvn verify and it formats something then you
> have another commit to issue. IMHO It is best to run mvn verify and then if
> everything passes issue a commit, or squash, or whatever works for you.
>
> Happy coding!