You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by n3llino <no...@github.com> on 2014/12/04 19:50:42 UTC

[jclouds] JCLOUDS-578: replaced request headers with swift object corresponding on... (#623)

Modifications in order to allow to set custom headers to swift object
You can merge this Pull Request by running:

  git pull https://github.com/n3llino/jclouds JCLOUDS-578

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/623

-- Commit Summary --

  * JCLOUDS-578: replaced request headers with swift object corresponding ones

-- File Changes --

    M apis/swift/src/main/java/org/jclouds/openstack/swift/binders/BindSwiftObjectMetadataToRequest.java (6)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/623.patch
https://github.com/jclouds/jclouds/pull/623.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/623

Re: [jclouds] JCLOUDS-578: replaced request headers with swift object corresponding on... (#623)

Posted by n3llino <no...@github.com>.

Hi @jdaggett , in my usage of SwiftObject setting all headers via setAllHeaders(MultiMap<String, String> headers) method or just putting keys-values pairs in the headers map just don't work when publishing files (at least on Rackspace, i didn't try any other providers). Looking for a solution i found and applied the one i proposed locally and it now works. @zack-shoylev i'm acting as you suggested, using a locally built jclouds library at the moment. Thank you

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/623#issuecomment-66254233

Re: [jclouds] JCLOUDS-578: replaced request headers with swift object corresponding on... (#623)

Posted by Zack Shoylev <no...@github.com>.

Is there a test for this?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/623#issuecomment-65708528

Re: [jclouds] JCLOUDS-578: replaced request headers with swift object corresponding on... (#623)

Posted by Jeremy Daggett <no...@github.com>.

@n3llino The `SwiftObject` has a [`setAllHeaders(MultiMap<String, String> headers)`](https://github.com/jclouds/jclouds/blob/master/apis/swift/src/main/java/org/jclouds/openstack/swift/domain/SwiftObject.java#L36) method to perform this operation. Can you please clarify your intent for this PR?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/623#issuecomment-66164008

Re: [jclouds] JCLOUDS-578: replaced request headers with swift object corresponding on... (#623)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds #1990](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1990/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/623#issuecomment-65776020

Re: [jclouds] JCLOUDS-578: replaced request headers with swift object corresponding on... (#623)

Posted by Zack Shoylev <no...@github.com>.

Also 1.6 will probably not be release again. I suggest you make a PR with a test for 1.8.x

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/623#issuecomment-65721804

Re: [jclouds] JCLOUDS-578: replaced request headers with swift object corresponding on... (#623)

Posted by Zack Shoylev <no...@github.com>.

Personally, I don't think we can commit to a 1.6.x release at this time. But maybe there is a workaround. You can try to build your own 1.6.x branch and use that maybe (at least for now). The next release is at least a few weeks away, anyways.
We might still want to include this fix in one of the newer branches though.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/623#issuecomment-65833690

Re: [jclouds] JCLOUDS-578: replaced request headers with swift object corresponding on... (#623)

Posted by Andrew Phillips <no...@github.com>.

> We might still want to include this fix in one of the newer branches though

@zack-shoylev Since this is against the old swift provider, what would the plan be here? Also: do you know whether the behaviour added here is already possible in openstack-swift?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/623#issuecomment-65880006

Re: [jclouds] JCLOUDS-578: replaced request headers with swift object corresponding on... (#623)

Posted by Zack Shoylev <no...@github.com>.

We are still looking into it. I expect @jdaggett will chime in as well.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/623#issuecomment-66158427

Re: [jclouds] JCLOUDS-578: replaced request headers with swift object corresponding on... (#623)

Posted by n3llino <no...@github.com>.

Hi, I just pushed a test, hope it's ok.
I'm making pull requests on 1.6.x since i'm using it in productions and i see there are many differences between the two versions (deprecated/removed methods) so i was hoping in a new realease even if it's not the last version

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/623#issuecomment-65772315

Re: [jclouds] JCLOUDS-578: replaced request headers with swift object corresponding on... (#623)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds #1987](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1987/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/623#issuecomment-65695754

Re: [jclouds/jclouds] JCLOUDS-578: replaced request headers with swift object corresponding on... (#623)

Posted by Andrew Gaul <no...@github.com>.

Closing this as it applies to the removed swift provider.  Please test against the new openstack-swift provider.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/623#issuecomment-326688560

Re: [jclouds/jclouds] JCLOUDS-578: replaced request headers with swift object corresponding on... (#623)

Posted by Andrew Gaul <no...@github.com>.

Closed #623.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/623#event-1232056098