[jira] [Commented] (DRILL-8268) Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-8268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570049#comment-17570049 ] 

ASF GitHub Bot commented on DRILL-8268:
---------------------------------------

jnturton opened a new pull request, #2610:
URL: https://github.com/apache/drill/pull/2610

   # [DRILL-8268](https://issues.apache.org/jira/browse/DRILL-8268): Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default
   
   ## Description
   
   New exclusions of slf4j-reload4j are required in the Hadoop 2 profile, probably due to the upgrade of Hadoop from 2.10.1 to 2.10.2. The netty-all metapackage entered the dependency tree with the change introducing the Netty bom bringing many uneeded libs with it.
   
   The heap memory usage limiting logic in the REST server is disabled by default since query results are streamed. This change aims to let the Java GC to now do its job without interference and if that results in OOM under a constant load then there is good evidence for a heap leak which must be tracked and completely resolved anyway, not mitigated or "swept under a rug".
   
   ## Documentation
   N/A
   
   ## Testing
   Lib exclusions: successful build and launch under the Hadoop 2 profile
   Heap memory usage: new (or existing) performance test in the drill-test-framework.
   




> Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default
> ---------------------------------------------------------------------------
>
>                 Key: DRILL-8268
>                 URL: https://issues.apache.org/jira/browse/DRILL-8268
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.20.1
>            Reporter: James Turton
>            Assignee: James Turton
>            Priority: Major
>             Fix For: 1.20.2
>
>
> New exclusions of slf4j-reload4j are required in the Hadoop 2 profile, probably due to the upgrade of Hadoop from 2.10.1 to 2.10.2. The netty-all metapackage entered the dependency tree with the change introducing the Netty bom bringing many uneeded libs with it.
> The heap memory usage limiting logic in the REST server is disabled by default since query results are streamed. This change aims to let the Java GC to now do its job without interference and if that results in OOM under a constant load then there is good evidence for a heap leak which must be tracked and completely resolved anyway, not mitigated or "swept under a rug".



--
This message was sent by Atlassian Jira
(v8.20.10#820010)