You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "liang3zy22 (via GitHub)" <gi...@apache.org> on 2023/03/13 02:43:25 UTC

[GitHub] [spark] liang3zy22 commented on a diff in pull request #40347: [SPARK-42711][BUILD]Update usage info for sbt tool

liang3zy22 commented on code in PR #40347:
URL: https://github.com/apache/spark/pull/40347#discussion_r1133395930


##########
build/sbt:
##########
@@ -17,7 +17,7 @@
 # limitations under the License.
 #
 
-SELF=$(cd $(dirname $0) && pwd)
+SELF=$(cd "$(dirname "$0")" && pwd)

Review Comment:
   This is shellcheck error/warning fix. I think we can keep it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org