You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/06/09 05:54:25 UTC
Re: Review Request 20138: Cleaned up test to use
cgroups::memory::limit_in_bytes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20138/
-----------------------------------------------------------
(Updated June 8, 2014, 8:54 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos-git
Description
-------
Cleaned up test to use cgroups::memory::limit_in_bytes
Diffs (updated)
-----
src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753
Diff: https://reviews.apache.org/r/20138/diff/
Testing
-------
make check
Thanks,
Ian Downes
Re: Review Request 20138: Cleaned up test to use
cgroups::memory::limit_in_bytes
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20138/#review45253
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20137, 20138]
All tests passed.
- Dominic Hamon
On June 9, 2014, 3:54 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20138/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 3:54 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Cleaned up test to use cgroups::memory::limit_in_bytes
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753
>
> Diff: https://reviews.apache.org/r/20138/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20138: Cleaned up test to use
cgroups::memory::limit_in_bytes
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20138/#review45576
-----------------------------------------------------------
Bad patch!
Reviews applied: [20138]
Failed command: git apply --index 20138.patch
Error:
error: patch failed: src/tests/cgroups_tests.cpp:500
error: src/tests/cgroups_tests.cpp: patch does not apply
- Mesos ReviewBot
On June 12, 2014, 9:49 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20138/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 9:49 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Cleaned up test to use cgroups::memory::limit_in_bytes
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753
>
> Diff: https://reviews.apache.org/r/20138/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20138: Cleaned up test to use
cgroups::memory::limit_in_bytes
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20138/#review46034
-----------------------------------------------------------
Bad patch!
Reviews applied: [20138]
Failed command: git apply --index 20138.patch
Error:
error: patch failed: src/tests/cgroups_tests.cpp:516
error: src/tests/cgroups_tests.cpp: patch does not apply
- Mesos ReviewBot
On June 17, 2014, 9:27 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20138/
> -----------------------------------------------------------
>
> (Updated June 17, 2014, 9:27 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Cleaned up test to use cgroups::memory::limit_in_bytes
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp bfb585818daacfa6dc605ba8430b097cfea7cafc
>
> Diff: https://reviews.apache.org/r/20138/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20138: Cleaned up test to use
cgroups::memory::limit_in_bytes
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20138/
-----------------------------------------------------------
(Updated June 17, 2014, 2:27 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Rebased.
Repository: mesos-git
Description
-------
Cleaned up test to use cgroups::memory::limit_in_bytes
Diffs (updated)
-----
src/tests/cgroups_tests.cpp bfb585818daacfa6dc605ba8430b097cfea7cafc
Diff: https://reviews.apache.org/r/20138/diff/
Testing
-------
make check
Thanks,
Ian Downes
Re: Review Request 20138: Cleaned up test to use
cgroups::memory::limit_in_bytes
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20138/
-----------------------------------------------------------
(Updated June 12, 2014, 9:49 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
assigning to @bmahler to shepherd -- vinod.
Repository: mesos-git
Description
-------
Cleaned up test to use cgroups::memory::limit_in_bytes
Diffs
-----
src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753
Diff: https://reviews.apache.org/r/20138/diff/
Testing
-------
make check
Thanks,
Ian Downes
Re: Review Request 20138: Cleaned up test to use
cgroups::memory::limit_in_bytes
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20138/#review45529
-----------------------------------------------------------
Ship it!
src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/20138/#comment80375>
Indent like you did below?
- Ben Mahler
On June 9, 2014, 3:54 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20138/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 3:54 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Cleaned up test to use cgroups::memory::limit_in_bytes
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753
>
> Diff: https://reviews.apache.org/r/20138/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20138: Cleaned up test to use
cgroups::memory::limit_in_bytes
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20138/#review45049
-----------------------------------------------------------
Bad patch!
Reviews applied: [20137, 20138]
Failed command: ./support/mesos-style.py
Error:
Checking 468 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
src/tests/cgroups_tests.cpp:521: Lines should be <= 80 characters long [whitespace/line_length] [2]
Total errors found: 1
- Mesos ReviewBot
On June 9, 2014, 3:54 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20138/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 3:54 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Cleaned up test to use cgroups::memory::limit_in_bytes
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753
>
> Diff: https://reviews.apache.org/r/20138/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>