[GitHub] [spark] iRakson commented on issue #27648: [SPARK-24994][SQL] : Support filter pushdown for short and byte without explicit casting

[GitBox <gi...@apache.org>]

iRakson commented on issue #27648: [SPARK-24994][SQL] : Support filter pushdown for short and byte without explicit casting
URL: https://github.com/apache/spark/pull/27648#issuecomment-589515318
 
 
   
   > Is that pushdown legal? if `id` is short, `id = 2` is parsed as `cast(id as int) = 2`. So, I feel that the semantics are different between them.
   
   Naive users might not cast `literal` to `shortType` when passing a value within short range.
   Also, if there are large number of queries which deals with short and byte fields, it is cumbersome to always explicitly cast them. 
   In those cases users can't get push-down benefits.
   
   In my opinion we should push the filter if `literals` are in `short`/`byte` range.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org