[GitHub] [incubator-nuttx] saramonteiro opened a new pull request #4139: xtensa/esp32: Fixes termios issue.

[GitBox <gi...@apache.org>]

saramonteiro opened a new pull request #4139:
URL: https://github.com/apache/incubator-nuttx/pull/4139


   ## Summary
   
   This MR fixes a configuration issue that was found when testing termios example.
   The issue was happening because CONF 0 and CONF 1 registers were temporarily cleared in shutdown function
   and RX_FIFO_FULL interrupt was being enabled before CONF 1 has been reconfigured in setup function.
   This was leading to trigger RX_FIFO_FULL interrupt constantly and hanging the code.
   It was solved by changing the sequence of interrupt configuration, placing it after the configuration of registers conf 0 and conf 1. Besides that, although not necessary anymore, the clearance of CONF 0 and CONF 1 registers was removed because setup function overwrites them, it doesn't modify, so this was actually unnecessary code. 
   
   ## Impact
   
   From now on, termios support is working on ESP32.
   
   ## Test
   
   Termios example.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4139: xtensa/esp32: Fixes termios issue.

[GitBox <gi...@apache.org>]

xiaoxiang781216 merged pull request #4139:
URL: https://github.com/apache/incubator-nuttx/pull/4139


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org