You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/12/16 21:19:36 UTC

[GitHub] [pulsar] phreed opened a new pull request #5871: [Issue 5725][localrun] Set connector's directory from system properties as well as environment parameter.

phreed opened a new pull request #5871: [Issue 5725][localrun] Set connector's directory from system properties as well as environment parameter.
URL: https://github.com/apache/pulsar/pull/5871
 
 
   #5725 
   
   ### Motivation
   
   I am developing a gradle plugin for pulsar. 
   The main task for the pulsar-gradle-plugin is to run sink-connectors, source-connectors, functions as localrun processes. 
   As outlined in https://pulsar.apache.org/docs/en/functions-debug/#debug-with-localrun-mode
   This makes debugging of these components from withing IDE (idea) simpler. 
   
   ### Modifications
   
   System.getenv("PULSAR_HOME")
   cannot be changed programmatically from java and consequently from the gradle plugin (written in java).
   This can be corrected by first checking for the "pulsar.home.path" system property.
   System.getProperty("pulsar.home.path").
   To allow more flexibility in the placement of the connectors the use of 
   System.getProperty("pulsar.connector.path") is also allowed.
   
   ### Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - The public API:  is extended by this change. It is possible to set system properties which change the behavior.
   
   ### Documentation
   
   This will change the documentation for 
   https://pulsar.apache.org/docs/en/functions-debug/#debug-with-localrun-mode
   Currently the documentation is missing a mention of the PULSAR_HOME environment variable. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services