[jira] Commented: (HADOOP-5732) SFTP FileSystem

["Chris Douglas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705521#action_12705521 ] 

Chris Douglas commented on HADOOP-5732:
---------------------------------------

Thanks for creating the patch. This looks good; a few comments:

* Throwing a RuntimeException (SFTPException) from FileSystem methods seems excessive; IOException should suffice.
* SFTPInputStream could equivalently and more succinctly extend FSInputStream. It can probably be a package-private class.
* The patch should update the ivy configs if it adds a jsch dependency. I'm sorry, but I have no good references on how to do this.
* Defaulting "recursive" to true in {{delete}} might be too aggressive.
* Note that {{delete(Path f)}} has been deprecated and removed in trunk, so at least two of the delete overrides can be removed
* Re-thrown exceptions should retain the original cause, not just the message (e.g. {{rename}})
* Any particular reason for not supporting setting the working directory?

> SFTP FileSystem
> ---------------
>
>                 Key: HADOOP-5732
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5732
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: fs
>         Environment: Any environment
>            Reporter: Íñigo Goiri
>            Priority: Minor
>         Attachments: HADOOP-FS-SFTP.patch, SFTPException.java, SFTPFileSystem.java, SFTPInputStream.java
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I have implemented a FileSystem that supports SFTP. It uses JSch (http://www.jcraft.com/jsch/) in order to manage SFTP.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.