You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by swegner <gi...@git.apache.org> on 2016/09/29 21:49:17 UTC

[GitHub] incubator-beam pull request #1029: [BEAM-691] Correctly implement display da...

GitHub user swegner opened a pull request:

    https://github.com/apache/incubator-beam/pull/1029

    [BEAM-691] Correctly implement display data for DataflowRunner Read transforms

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/swegner/incubator-beam displaydata-streaming

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1029.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1029
    
----
commit cda01dbc4038a3a07b808d9d868afee666b219cb
Author: Scott Wegner <sw...@google.com>
Date:   2016-09-29T21:43:14Z

    Set transform names in DisplayDataEvaluator
    
    If a transform name is unset, a runner may infer the name from
    the class simple name, which fails with anonymous classes. In order
    to be more generically useful, we set transform names within the
    DisplayDataEvaluator.

commit b0ce3f9d26eb7fb1d5b427a987939d555667c408
Author: Scott Wegner <sw...@google.com>
Date:   2016-09-29T21:45:57Z

    Handle anonymous classes in DataflowUnboundedReadFromBoundedSource.getKind()

commit 50d8d34d6f6b7b5d907906431844b41f2d9c7b24
Author: Scott Wegner <sw...@google.com>
Date:   2016-09-29T21:46:33Z

    Correctly implement display data for DataflowRunner Read transforms
    
    The DataflowRunner will replace usages of the Read transform with
    interally-wrapped implementations for streaming and bounded cases.
    We were not properly passing display data between these usages.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #1029: [BEAM-691] Correctly implement display da...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1029


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---