You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/17 12:06:12 UTC

[GitHub] [airflow] kazanzhy edited a comment on pull request #19639: Remove `allowed_conn_types` from SqlSensor

kazanzhy edited a comment on pull request #19639:
URL: https://github.com/apache/airflow/pull/19639#issuecomment-971516564


   > Oh no the test suite doesn’t like this
   >
   Yep. That's not good. In this situation, I see two ways.
    1. Inherit SqlSensor from BaseSensorOperator and BaseSqlOperator. The last one already makes this check.
    2. Somehow edit all tests in `tests/sensors/test_sql_sensor.py` to solve these errors. But I haven't suggestions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org