You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/01/26 08:07:38 UTC

[GitHub] [iotdb] chengjianyun commented on pull request #4964: Apply string intern for device String

chengjianyun commented on pull request #4964:
URL: https://github.com/apache/iotdb/pull/4964#issuecomment-1021956929


   > Hi, is there any detailed reason about the memory leak risk?
   
   `cachedDevicePool` never remove its key which is not reasonable. For example, if we delete some storage groups or timeseries, some string would be never used but they are always kept in `cachedDevicePool` which cause memory leak.
   
   For string intern, JVM takes care of remove the useless string objects.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org