You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/09 12:47:26 UTC

[GitHub] [flink] SteNicholas commented on a change in pull request #17691: [FLINK-24586][table] SQL functions should return STRING instead of VARCHAR(2000)

SteNicholas commented on a change in pull request #17691:
URL: https://github.com/apache/flink/pull/17691#discussion_r745582828



##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/type/FlinkReturnTypes.java
##########
@@ -104,9 +104,9 @@ public RelDataType inferReturnType(SqlOperatorBinding opBinding) {
                 }
             };
 
-    /** Type-inference strategy that always returns "VARCHAR(2000)" with nulls always allowed. */
-    public static final SqlReturnTypeInference VARCHAR_2000_NULLABLE =
-            ReturnTypes.cascade(ReturnTypes.VARCHAR_2000, SqlTypeTransforms.FORCE_NULLABLE);
+    public static final SqlReturnTypeInference VARCHAR_NULLABLE =

Review comment:
       @slinkydeveloper , the `VARCHAR_FORCE_NULLABLE` makes sense to me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org