[GitHub] [spark] juliuszsompolski commented on a diff in pull request #38941: [SPARK-41498] Propagate metadata through Union

[GitBox <gi...@apache.org>]

juliuszsompolski commented on code in PR #38941:
URL: https://github.com/apache/spark/pull/38941#discussion_r1051033080


##########
sql/core/src/test/scala/org/apache/spark/sql/connector/MetadataColumnSuite.scala:
##########
@@ -232,4 +237,175 @@ class MetadataColumnSuite extends DatasourceV2SQLBase {
       )
     }
   }
+
+  test("SPARK-41498: Metadata column is propagated through union") {

Review Comment:
   could we also add a positive example with more complicated columns?
   e.g. selecting _partition and _metadata; or projecting _metadata to only select file_name so that nested column pruning kicks in?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org