You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:41:21 UTC
[GitHub] [tomcat] mcroteau opened a new pull request #327: Slight ui modifications
mcroteau opened a new pull request #327:
URL: https://github.com/apache/tomcat/pull/327
Just a feeler pull request, please let me know if you approve of the ui direction. Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] ChristopherSchultz commented on a change in pull request #327: Slight ui modifications
Posted by GitBox <gi...@apache.org>.
ChristopherSchultz commented on a change in pull request #327:
URL: https://github.com/apache/tomcat/pull/327#discussion_r461586817
##########
File path: java/org/apache/catalina/manager/Constants.java
##########
@@ -39,38 +39,65 @@
"<head>\n" +
"<style>\n" +
org.apache.catalina.util.TomcatCSS.TOMCAT_CSS + "\n" +
+ " #manager-wrapper {\n" +
+ " min-width: 720px;\n" +
+ " max-width: 1000px;\n" +
+ " margin: 20px auto;\n" +
+ " background: #fff;\n" +
+ " padding: 20px 30px;\n" +
+ " }\n" +
" table {\n" +
" width: 100%;\n" +
+ " margin: 10px auto 0px auto;\n" +
" }\n" +
" td.page-title {\n" +
+ " font-size:52px; \n" +
" text-align: center;\n" +
" vertical-align: top;\n" +
" font-family:sans-serif,Tahoma,Arial;\n" +
" font-weight: bold;\n" +
" background: white;\n" +
+ " text-align: left;\n" +
+ " padding-top:20px\n" +
" color: black;\n" +
+ " padding-top: 24px;\n" +
" }\n" +
+ " td.page-title font{\n" +
+ " font-size:52px;\n" +
+ " }\n" +
+ " #manager-section{\n" +
+ " margin-bottom:20px;\n" +
+ " }\n" +
+ " #server-section{\n" +
+ " margin-top:20px;\n" +
+ " margin-bottom:170px;\n" +
+ " }\n" +
+ " #copyright{\n" +
+ " display:block;\n" +
+ " margin-bottom:30px;\n" +
+ " }\n" +
" td.title {\n" +
+ " color: #fff;\n" +
" text-align: left;\n" +
" vertical-align: top;\n" +
" font-family:sans-serif,Tahoma,Arial;\n" +
- " font-style:italic;\n" +
+ " font-size:23px;\n" +
Review comment:
Try to use relative sizes and not explicit pixel sizes. It will allow the UI to scale much more nicely on a variety of devices.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] mcroteau commented on a change in pull request #327: Slight ui modifications
Posted by GitBox <gi...@apache.org>.
mcroteau commented on a change in pull request #327:
URL: https://github.com/apache/tomcat/pull/327#discussion_r461979720
##########
File path: java/org/apache/catalina/manager/Constants.java
##########
@@ -39,38 +39,65 @@
"<head>\n" +
"<style>\n" +
org.apache.catalina.util.TomcatCSS.TOMCAT_CSS + "\n" +
+ " #manager-wrapper {\n" +
+ " min-width: 720px;\n" +
+ " max-width: 1000px;\n" +
+ " margin: 20px auto;\n" +
+ " background: #fff;\n" +
+ " padding: 20px 30px;\n" +
+ " }\n" +
" table {\n" +
" width: 100%;\n" +
+ " margin: 10px auto 0px auto;\n" +
" }\n" +
" td.page-title {\n" +
+ " font-size:52px; \n" +
" text-align: center;\n" +
" vertical-align: top;\n" +
" font-family:sans-serif,Tahoma,Arial;\n" +
" font-weight: bold;\n" +
" background: white;\n" +
+ " text-align: left;\n" +
+ " padding-top:20px\n" +
" color: black;\n" +
+ " padding-top: 24px;\n" +
" }\n" +
+ " td.page-title font{\n" +
+ " font-size:52px;\n" +
+ " }\n" +
+ " #manager-section{\n" +
+ " margin-bottom:20px;\n" +
+ " }\n" +
+ " #server-section{\n" +
+ " margin-top:20px;\n" +
+ " margin-bottom:170px;\n" +
+ " }\n" +
+ " #copyright{\n" +
+ " display:block;\n" +
+ " margin-bottom:30px;\n" +
+ " }\n" +
" td.title {\n" +
+ " color: #fff;\n" +
" text-align: left;\n" +
" vertical-align: top;\n" +
" font-family:sans-serif,Tahoma,Arial;\n" +
- " font-style:italic;\n" +
+ " font-size:23px;\n" +
" font-weight: bold;\n" +
- " background: #D2A41C;\n" +
+ " background: #8F8464;\n" +
Review comment:
Thank you. I made sure to use a brown that compliments the logo + theme. I use https://colorschemedesigner.com/csd-3.5/.
##########
File path: java/org/apache/catalina/manager/Constants.java
##########
@@ -39,38 +39,65 @@
"<head>\n" +
"<style>\n" +
org.apache.catalina.util.TomcatCSS.TOMCAT_CSS + "\n" +
+ " #manager-wrapper {\n" +
+ " min-width: 720px;\n" +
+ " max-width: 1000px;\n" +
+ " margin: 20px auto;\n" +
+ " background: #fff;\n" +
+ " padding: 20px 30px;\n" +
+ " }\n" +
" table {\n" +
" width: 100%;\n" +
+ " margin: 10px auto 0px auto;\n" +
" }\n" +
" td.page-title {\n" +
+ " font-size:52px; \n" +
" text-align: center;\n" +
" vertical-align: top;\n" +
" font-family:sans-serif,Tahoma,Arial;\n" +
" font-weight: bold;\n" +
" background: white;\n" +
+ " text-align: left;\n" +
+ " padding-top:20px\n" +
" color: black;\n" +
+ " padding-top: 24px;\n" +
" }\n" +
+ " td.page-title font{\n" +
+ " font-size:52px;\n" +
+ " }\n" +
+ " #manager-section{\n" +
+ " margin-bottom:20px;\n" +
+ " }\n" +
+ " #server-section{\n" +
+ " margin-top:20px;\n" +
+ " margin-bottom:170px;\n" +
+ " }\n" +
+ " #copyright{\n" +
+ " display:block;\n" +
+ " margin-bottom:30px;\n" +
+ " }\n" +
" td.title {\n" +
+ " color: #fff;\n" +
" text-align: left;\n" +
" vertical-align: top;\n" +
" font-family:sans-serif,Tahoma,Arial;\n" +
- " font-style:italic;\n" +
+ " font-size:23px;\n" +
" font-weight: bold;\n" +
- " background: #D2A41C;\n" +
+ " background: #8F8464;\n" +
Review comment:
Thank you. I made sure to use a brown that compliments the logo + theme. I used https://colorschemedesigner.com/csd-3.5/.
##########
File path: java/org/apache/catalina/manager/Constants.java
##########
@@ -39,38 +39,65 @@
"<head>\n" +
"<style>\n" +
org.apache.catalina.util.TomcatCSS.TOMCAT_CSS + "\n" +
+ " #manager-wrapper {\n" +
+ " min-width: 720px;\n" +
+ " max-width: 1000px;\n" +
+ " margin: 20px auto;\n" +
+ " background: #fff;\n" +
+ " padding: 20px 30px;\n" +
+ " }\n" +
" table {\n" +
" width: 100%;\n" +
+ " margin: 10px auto 0px auto;\n" +
" }\n" +
" td.page-title {\n" +
+ " font-size:52px; \n" +
" text-align: center;\n" +
" vertical-align: top;\n" +
" font-family:sans-serif,Tahoma,Arial;\n" +
" font-weight: bold;\n" +
" background: white;\n" +
+ " text-align: left;\n" +
+ " padding-top:20px\n" +
" color: black;\n" +
+ " padding-top: 24px;\n" +
" }\n" +
+ " td.page-title font{\n" +
+ " font-size:52px;\n" +
+ " }\n" +
+ " #manager-section{\n" +
+ " margin-bottom:20px;\n" +
+ " }\n" +
+ " #server-section{\n" +
+ " margin-top:20px;\n" +
+ " margin-bottom:170px;\n" +
+ " }\n" +
+ " #copyright{\n" +
+ " display:block;\n" +
+ " margin-bottom:30px;\n" +
+ " }\n" +
" td.title {\n" +
+ " color: #fff;\n" +
" text-align: left;\n" +
" vertical-align: top;\n" +
" font-family:sans-serif,Tahoma,Arial;\n" +
- " font-style:italic;\n" +
+ " font-size:23px;\n" +
" font-weight: bold;\n" +
- " background: #D2A41C;\n" +
+ " background: #8F8464;\n" +
Review comment:
Thank you. I made sure to use a brown that compliments the logo + theme. I use https://colorschemedesigner.com/csd-3.5/ for all my ui work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf closed pull request #327: Slight ui modifications
Posted by GitBox <gi...@apache.org>.
markt-asf closed pull request #327:
URL: https://github.com/apache/tomcat/pull/327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] isapir commented on a change in pull request #327: Slight ui modifications
Posted by GitBox <gi...@apache.org>.
isapir commented on a change in pull request #327:
URL: https://github.com/apache/tomcat/pull/327#discussion_r463257146
##########
File path: java/org/apache/catalina/manager/Constants.java
##########
@@ -39,38 +39,65 @@
"<head>\n" +
"<style>\n" +
org.apache.catalina.util.TomcatCSS.TOMCAT_CSS + "\n" +
+ " #manager-wrapper {\n" +
+ " min-width: 720px;\n" +
+ " max-width: 1000px;\n" +
+ " margin: 20px auto;\n" +
+ " background: #fff;\n" +
+ " padding: 20px 30px;\n" +
+ " }\n" +
" table {\n" +
" width: 100%;\n" +
+ " margin: 10px auto 0px auto;\n" +
" }\n" +
" td.page-title {\n" +
+ " font-size:52px; \n" +
" text-align: center;\n" +
" vertical-align: top;\n" +
" font-family:sans-serif,Tahoma,Arial;\n" +
" font-weight: bold;\n" +
" background: white;\n" +
+ " text-align: left;\n" +
+ " padding-top:20px\n" +
" color: black;\n" +
+ " padding-top: 24px;\n" +
" }\n" +
+ " td.page-title font{\n" +
+ " font-size:52px;\n" +
+ " }\n" +
+ " #manager-section{\n" +
+ " margin-bottom:20px;\n" +
+ " }\n" +
+ " #server-section{\n" +
+ " margin-top:20px;\n" +
+ " margin-bottom:170px;\n" +
+ " }\n" +
+ " #copyright{\n" +
+ " display:block;\n" +
+ " margin-bottom:30px;\n" +
+ " }\n" +
" td.title {\n" +
+ " color: #fff;\n" +
" text-align: left;\n" +
" vertical-align: top;\n" +
" font-family:sans-serif,Tahoma,Arial;\n" +
- " font-style:italic;\n" +
+ " font-size:23px;\n" +
" font-weight: bold;\n" +
- " background: #D2A41C;\n" +
+ " background: #8F8464;\n" +
Review comment:
Personally I'm against color theme changes without discussing them first and reaching a consensus
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] isapir commented on a change in pull request #327: Slight ui modifications
Posted by GitBox <gi...@apache.org>.
isapir commented on a change in pull request #327:
URL: https://github.com/apache/tomcat/pull/327#discussion_r461933922
##########
File path: java/org/apache/catalina/manager/Constants.java
##########
@@ -39,38 +39,65 @@
"<head>\n" +
"<style>\n" +
org.apache.catalina.util.TomcatCSS.TOMCAT_CSS + "\n" +
+ " #manager-wrapper {\n" +
+ " min-width: 720px;\n" +
+ " max-width: 1000px;\n" +
+ " margin: 20px auto;\n" +
+ " background: #fff;\n" +
+ " padding: 20px 30px;\n" +
+ " }\n" +
" table {\n" +
" width: 100%;\n" +
+ " margin: 10px auto 0px auto;\n" +
" }\n" +
" td.page-title {\n" +
+ " font-size:52px; \n" +
" text-align: center;\n" +
" vertical-align: top;\n" +
" font-family:sans-serif,Tahoma,Arial;\n" +
" font-weight: bold;\n" +
" background: white;\n" +
+ " text-align: left;\n" +
+ " padding-top:20px\n" +
" color: black;\n" +
+ " padding-top: 24px;\n" +
" }\n" +
+ " td.page-title font{\n" +
+ " font-size:52px;\n" +
+ " }\n" +
+ " #manager-section{\n" +
+ " margin-bottom:20px;\n" +
+ " }\n" +
+ " #server-section{\n" +
+ " margin-top:20px;\n" +
+ " margin-bottom:170px;\n" +
+ " }\n" +
+ " #copyright{\n" +
+ " display:block;\n" +
+ " margin-bottom:30px;\n" +
+ " }\n" +
" td.title {\n" +
+ " color: #fff;\n" +
" text-align: left;\n" +
" vertical-align: top;\n" +
" font-family:sans-serif,Tahoma,Arial;\n" +
- " font-style:italic;\n" +
+ " font-size:23px;\n" +
" font-weight: bold;\n" +
- " background: #D2A41C;\n" +
+ " background: #8F8464;\n" +
Review comment:
This color change modifies the theme, specifically the dark Gold background which matches the body of the Tomcat logo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org