You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Brijesh Bhalala <br...@gmail.com> on 2023/03/23 06:45:02 UTC
Review Request 74358: RANGER-4095: On users/groups/roles page in settings - The page number can be decreased to zero and negative and can be increased beyond max pages available to show.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74358/
-----------------------------------------------------------
Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4095
https://issues.apache.org/jira/browse/RANGER-4095
Repository: ranger
Description
-------
Behaviour in React UI:
In users/groups/roles page in settings - The page number can be decreased to zero and negative and can be increased beyond max pages available to show.
Behaviour in Backbone JS UI:
Not available
Expected Behaviour:
Although logically the result is not affected through this behaviour as for zero and negative page no. its showing page 1 and for page no greater than max available page its showing the data of max page only.
But from UI perspective we should at-least restrict the increase and decrease page no feature to min and max limit.
Diffs
-----
security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx 4b77d526c
security-admin/src/main/webapp/react-webapp/src/styles/style.css 1cb441373
Diff: https://reviews.apache.org/r/74358/diff/1/
Testing
-------
1)Build and Verified Ranger Admin setup with this changes.
2)Verified the Following things:-
- All the listing tables.
Thanks,
Brijesh Bhalala
Re: Review Request 74358: RANGER-4095: On users/groups/roles page in settings - The page number can be decreased to zero and negative and can be increased beyond max pages available to show.
Posted by Mugdha Varadkar <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74358/#review225308
-----------------------------------------------------------
Ship it!
Ship It!
- Mugdha Varadkar
On March 29, 2023, 3:05 p.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74358/
> -----------------------------------------------------------
>
> (Updated March 29, 2023, 3:05 p.m.)
>
>
> Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
>
>
> Bugs: RANGER-4095
> https://issues.apache.org/jira/browse/RANGER-4095
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Behaviour in React UI:
>
> In users/groups/roles page in settings - The page number can be decreased to zero and negative and can be increased beyond max pages available to show.
>
>
> Behaviour in Backbone JS UI:
>
> Not available
>
>
> Expected Behaviour:
>
> Although logically the result is not affected through this behaviour as for zero and negative page no. its showing page 1 and for page no greater than max available page its showing the data of max page only.
>
> But from UI perspective we should at-least restrict the increase and decrease page no feature to min and max limit.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx 4b77d526c33dfffc679a7746af9853ec6d5082bd
> security-admin/src/main/webapp/react-webapp/src/styles/style.css 1cb4413733c9e51052b8e42f4b67017c2a203b3c
>
>
> Diff: https://reviews.apache.org/r/74358/diff/2/
>
>
> Testing
> -------
>
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the Following things:-
> - All the listing tables.
>
>
> Thanks,
>
> Brijesh Bhalala
>
>
Re: Review Request 74358: RANGER-4095: On users/groups/roles page in settings - The page number can be decreased to zero and negative and can be increased beyond max pages available to show.
Posted by Dhaval Rajpara <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74358/#review225310
-----------------------------------------------------------
Ship it!
Ship It!
- Dhaval Rajpara
On March 29, 2023, 3:05 p.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74358/
> -----------------------------------------------------------
>
> (Updated March 29, 2023, 3:05 p.m.)
>
>
> Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
>
>
> Bugs: RANGER-4095
> https://issues.apache.org/jira/browse/RANGER-4095
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Behaviour in React UI:
>
> In users/groups/roles page in settings - The page number can be decreased to zero and negative and can be increased beyond max pages available to show.
>
>
> Behaviour in Backbone JS UI:
>
> Not available
>
>
> Expected Behaviour:
>
> Although logically the result is not affected through this behaviour as for zero and negative page no. its showing page 1 and for page no greater than max available page its showing the data of max page only.
>
> But from UI perspective we should at-least restrict the increase and decrease page no feature to min and max limit.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx 4b77d526c33dfffc679a7746af9853ec6d5082bd
> security-admin/src/main/webapp/react-webapp/src/styles/style.css 1cb4413733c9e51052b8e42f4b67017c2a203b3c
>
>
> Diff: https://reviews.apache.org/r/74358/diff/2/
>
>
> Testing
> -------
>
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the Following things:-
> - All the listing tables.
>
>
> Thanks,
>
> Brijesh Bhalala
>
>
Re: Review Request 74358: RANGER-4095: On users/groups/roles page in settings - The page number can be decreased to zero and negative and can be increased beyond max pages available to show.
Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74358/
-----------------------------------------------------------
(Updated March 29, 2023, 3:05 p.m.)
Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4095
https://issues.apache.org/jira/browse/RANGER-4095
Repository: ranger
Description
-------
Behaviour in React UI:
In users/groups/roles page in settings - The page number can be decreased to zero and negative and can be increased beyond max pages available to show.
Behaviour in Backbone JS UI:
Not available
Expected Behaviour:
Although logically the result is not affected through this behaviour as for zero and negative page no. its showing page 1 and for page no greater than max available page its showing the data of max page only.
But from UI perspective we should at-least restrict the increase and decrease page no feature to min and max limit.
Diffs (updated)
-----
security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx 4b77d526c33dfffc679a7746af9853ec6d5082bd
security-admin/src/main/webapp/react-webapp/src/styles/style.css 1cb4413733c9e51052b8e42f4b67017c2a203b3c
Diff: https://reviews.apache.org/r/74358/diff/2/
Changes: https://reviews.apache.org/r/74358/diff/1-2/
Testing
-------
1)Build and Verified Ranger Admin setup with this changes.
2)Verified the Following things:-
- All the listing tables.
Thanks,
Brijesh Bhalala