[GitHub] nifi pull request #2915: NIFI-5388: enabled EL support for dynamic propertie...

[snagafritz <gi...@git.apache.org>]

GitHub user snagafritz opened a pull request:

    https://github.com/apache/nifi/pull/2915

    NIFI-5388: enabled EL support for dynamic properties of Kafka 1.0 processors

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    ```
    Started writing unit tests but it seemed trivial validating that the properties have EL support enabled. I will attach a video to the JIRA ticket of me verifying expected behavior for the Kafka consumer.
    ```
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Snagajob/nifi NIFI-5388

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2915.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2915
    
----
commit 76707086dfef73e2ee8e2ea9dd9f6d9c725b96be
Author: Corey Fritz <co...@...>
Date:   2018-07-17T01:06:01Z

    NIFI-5388: enabled EL support for dynamic properties of Kafka 1.0 processors

----


---

[GitHub] nifi pull request #2915: NIFI-5388: enabled EL support for dynamic propertie...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/2915


---

[GitHub] nifi issue #2915: NIFI-5388: enabled EL support for dynamic properties of Ka...

[MikeThomsen <gi...@git.apache.org>]

Github user MikeThomsen commented on the issue:

    https://github.com/apache/nifi/pull/2915
  
    @zenfenan the consumer one has input forbidden on it, so you won't get flowfiles there. For the publisher, my guess is it's probably being conservative about reconfiguring the producers, which isn't a bad call IMO.


---