You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/12/10 15:56:12 UTC

[PR] Improve ProjectionExpr documentation and comments [datafusion]

alamb opened a new pull request, #19263:
URL: https://github.com/apache/datafusion/pull/19263

   ## Which issue does this PR close?
   
   - related to https://github.com/apache/datafusion/pull/19111
   
   ## Rationale for this change
   
   While reviewing https://github.com/apache/datafusion/pull/19111 from @adriangb I found a few places that the documentation could be improved to give higher level context
   
   ## What changes are included in this PR?
   
   Update some docs and comments
   
   ## Are these changes tested?
   
   By cos
   
   ## Are there any user-facing changes?
   Just docs/comments. No functional changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] Improve ProjectionExpr documentation and comments [datafusion]

Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb merged PR #19263:
URL: https://github.com/apache/datafusion/pull/19263


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] Improve ProjectionExpr documentation and comments [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #19263:
URL: https://github.com/apache/datafusion/pull/19263#discussion_r2607241252


##########
datafusion/datasource-parquet/src/opener.rs:
##########
@@ -277,8 +277,9 @@ impl FileOpener for ParquetOpener {
             // - The table schema as defined by the TableProvider.
             //   This is what the user sees, what they get when they `SELECT * FROM table`, etc.
             // - The logical file schema: this is the table schema minus any hive partition columns and projections.
-            //   This is what the physicalfile schema is coerced to.
-            // - The physical file schema: this is the schema as defined by the parquet file. This is what the parquet file actually contains.
+            //   This is what the physical file schema is coerced to.
+            // - The physical file schema: this is the schema that the arrow-rs

Review Comment:
   I found the "what the file contains" confusing -- Parquet has different datatypes than Arrow



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org