You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "edmondop (via GitHub)" <gi...@apache.org> on 2025/01/29 13:04:03 UTC

Re: [PR] add manual trigger for extended tests in pull requests [datafusion]

edmondop commented on code in PR #14331:
URL: https://github.com/apache/datafusion/pull/14331#discussion_r1933841345


##########
.github/workflows/extended.yml:
##########
@@ -31,14 +31,38 @@ on:
   push:
     branches:
       - main
+  issue_comment:
+    types: [created]
+
+permissions:
+  pull-requests: write
 
 jobs:
+  # Check issue comment and notify that extended tests are running
+  check_issue_comment:
+    name: Check issue comment
+    runs-on: ubuntu-latest
+    if: github.event.issue.pull_request && github.event.comment.body == 'run extended tests'
+    steps:
+      - uses: actions/github-script@v7
+        with:
+          github-token: ${{secrets.GITHUB_TOKEN}}
+          script: |
+            github.rest.issues.createComment({

Review Comment:
   I wonder if we can create a check in the PR to show that the running the tests is in progress, 
   
   we can use https://octokit.github.io/rest.js/v21/#checks
   
   to create a check if the comment is available,
   
   and when the pipeline runs, we can update the check using the update the check
   
   ```js
   
   octokit.rest.checks.update({
           owner,
   repo,
   check_run_id,
   output.summary,
   output.annotations[].path,
   output.annotations[].start_line,
   output.annotations[].end_line,
   output.annotations[].annotation_level,
   output.annotations[].message,
   output.images[].alt,
   output.images[].image_url,
   actions[].label,
   actions[].description,
   actions[].identifier
         })
   ```
   
   see in the docs that I have linked the "Update a check run" under the checks api
   
   wdyt @alamb ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org