You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/08 08:42:20 UTC

[GitHub] [pulsar] BewareMyPower edited a comment on pull request #10850: maxTopicsPerNamespace check should exclude system topic.

BewareMyPower edited a comment on pull request #10850:
URL: https://github.com/apache/pulsar/pull/10850#issuecomment-856579893


   Could you add a test case to cover your change? Your test only covers the `isSystemTopic` method.
   
   I mean changing `AdminApiTest2#testMaxTopicsPerNamespace`. Could you manually create some system topics and see if the test could be affected?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org