[GitHub] [iotdb] Beyyes commented on a diff in pull request #6643: [IOTDB-3765] Reinforce DataNode startup process

[GitBox <gi...@apache.org>]

Beyyes commented on code in PR #6643:
URL: https://github.com/apache/iotdb/pull/6643#discussion_r920698623


##########
service-rpc/src/main/java/org/apache/iotdb/rpc/TSStatusCode.java:
##########
@@ -140,15 +140,14 @@ public enum TSStatusCode {
   REMOVE_CONFIGNODE_FAILED(908),
   REMOVE_CONFIGNODE_DUPLICATION(909),
   STOP_CONOFIGNODE_FAILED(910),
-  DATANODE_ALREADY_ACTIVATED(911),
-  PERSISTENCE_FAILURE(912),
-  DATANODE_NOT_EXIST(913),
-  DUPLICATE_REMOVE(914),
-  REQUEST_SIZE_EXCEED(915),
-  REGION_MIGRATE_FAILED(916),
-  LACK_REPLICATION(917),
-  DATANODE_STOP_ERROR(918),
-  REGION_LEADER_CHANGE_FAILED(919);
+  PERSISTENCE_FAILURE(911),

Review Comment:
   If we change the status code number, will this produce compatibility issues?
   For example, 
   PERSISTENCE_FAILURE(912) previously,
   PERSISTENCE_FAILURE(911) now.
   
   And have we use these status code in user guide documents?
   



##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/NodeManager.java:
##########
@@ -111,6 +110,9 @@ public DataSet registerDataNode(RegisterDataNodePlan registerDataNodePlan) {
       registerDataNodePlan.getInfo().getLocation().setDataNodeId(nodeInfo.generateNextNodeId());
       getConsensusManager().write(registerDataNodePlan);
 
+      // Adjust the maximum RegionGroup number of each StorageGroup
+      getClusterSchemaManager().adjustMaxRegionGroupCount();

Review Comment:
   Is this line described in the feishu doc? 



##########
confignode/src/main/java/org/apache/iotdb/confignode/persistence/NodeInfo.java:
##########
@@ -180,6 +179,7 @@ public TSStatus registerDataNode(RegisterDataNodePlan registerDataNodePlan) {
           nextNodeId.set(info.getLocation().getDataNodeId());
         }
       }
+      registeredDataNodes.put(info.getLocation().getDataNodeId(), info);

Review Comment:
   Why we lacked this line before~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org