[jira] [Commented] (HADOOP-15870) S3AInputStream.remainingInFile should use nextReadPos

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-15870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674021#comment-16674021 ] 

ASF GitHub Bot commented on HADOOP-15870:
-----------------------------------------

Github user steveloughran commented on the issue:

    https://github.com/apache/hadoop/pull/433
  
    As the usual test police, which S3 endpoint did you rerun all the hadoop-aws tests against? 
    https://hadoop.apache.org/docs/current/hadoop-aws/tools/hadoop-aws/testing.html
    
    This only takes < 10 minutes, even remotely
    
    ```
    mvn verify -Dparallel-tests -DtestsThreadCount=10 -Dscale
    # or with s3guard
    mvn verify -Dparallel-tests -DtestsThreadCount=10 -Ds3guard -Ddynamodb -Dscale
    ```
    
    I'll help with testing the other stores (azure wasb/abfs/adl), before the commit, but I'd appreciate the diligence here as it shows you've done the homework. thx



> S3AInputStream.remainingInFile should use nextReadPos
> -----------------------------------------------------
>
>                 Key: HADOOP-15870
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15870
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 2.8.4, 3.1.1
>            Reporter: Shixiong Zhu
>            Priority: Major
>
> Otherwise `remainingInFile` will not change after `seek`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org