You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/02/19 17:57:14 UTC

[GitHub] [geode-native] moleske opened a new pull request #747: GEODE-8949: Fix broken build inconsistent-missing-override

moleske opened a new pull request #747:
URL: https://github.com/apache/geode-native/pull/747


   Was failing to build on Mac
   
   Authored-by: M. Oleske <mi...@oleske.engineer>
   
   PR https://github.com/apache/geode-native/pull/746 caused a failure on Mac only it seems due to `SetUp` function from gTest not using override correctly.  Since the body was commented out and `scrubTestLogFiles` is used in `TearDown`, I just deleted the function to solve the problem


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] mmartell commented on pull request #747: GEODE-8949: Fix broken build inconsistent-missing-override

Posted by GitBox <gi...@apache.org>.
mmartell commented on pull request #747:
URL: https://github.com/apache/geode-native/pull/747#issuecomment-782388623


   Looks like PR pipeline has issues. Although this PR had 2 approvals, shouldn't have been able to merge due to failing Travis (clang-analyzer problem with ACE). Investigating.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] mmartell merged pull request #747: GEODE-8949: Fix broken build inconsistent-missing-override

Posted by GitBox <gi...@apache.org>.
mmartell merged pull request #747:
URL: https://github.com/apache/geode-native/pull/747


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org