You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/01/14 21:18:28 UTC
[GitHub] [maven-surefire] Tibor17 opened a new pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Tibor17 opened a new pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#issuecomment-1013485123
@michael-o
I hope the `maven-release-plugin` would not crash on this
```
<surefire-shared-utils.version>${project.version}</surefire-shared-utils.version>
<dependencies>
<dependency>
<groupId>org.apache.maven.surefire</groupId>
<artifactId>surefire-shared-utils</artifactId>
<version>${surefire-shared-utils.version}</version>
<classifier>shaded</classifier>
</dependency>
</dependencies>
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#issuecomment-1014904669
@slawekjaranowski
`SurefireDependencyResolver` was removed from the commit.
Squashed commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#discussion_r786331512
##########
File path: surefire-shared-utils/pom.xml
##########
@@ -100,5 +102,35 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <!-- First, install the project without tests -> mvn install -DskipTests
+ This is a workaround for IntelliJ IDEA, see https://youtrack.jetbrains.com/issue/IDEA-148573
+ IDEA is able to recognize external artifacts with classifiers. But IDEA expects modules and their artifacts
+ without classifier. If the version differs from project, the idea would understand it as external artifact.
+ -->
+ <id>ide-development</id>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-install-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>install-devel-jar</id>
+ <phase>install</phase>
+ <goals>
+ <goal>install-file</goal>
+ </goals>
+ <configuration>
+ <artifactId>surefire-shared-utils</artifactId>
+ <version>3-SNAPSHOT</version>
Review comment:
@slawekjaranowski
I spoke about it with @miachael-o , it is not Maven problem. The IDEA is an open source project and can be fixed, see [the ticket](https://youtrack.jetbrains.com/issue/IDEA-148573). These are two separate issues and they are in progress..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#discussion_r786190522
##########
File path: maven-failsafe-plugin/pom.xml
##########
@@ -266,12 +266,12 @@
<postBuildHookScript>verify</postBuildHookScript>
<settingsFile>src/it/settings.xml</settingsFile>
<skipInvocation>${skipTests}</skipInvocation>
- <streamLogs>true</streamLogs>
Review comment:
Because the info logs do not help. And debug logs cannot be read in the main logs.
Several days ago we fixed logs archives and so these logs of this module can be downloaded as a zip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 removed a comment on pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
Tibor17 removed a comment on pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#issuecomment-1013993635
@michael-o
I don't want to install and deploy the original POM. I want to have `dependency-reduced-pom.xml` after shading. So the classifier is attached but I do not want to have the original jar and POM because the dependencies affected already the ITs, the dependencies must not present in the POM any more. How can we do that? The shade plugin does not have this option, I think, so should we do it on the install/deploy level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#discussion_r786268662
##########
File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireDependencyResolver.java
##########
@@ -61,20 +62,21 @@
{
static final String PROVIDER_GROUP_ID = "org.apache.maven.surefire";
- private static final String[] PROVIDER_CLASSPATH_ORDER = {
- "surefire-junit3",
- "surefire-junit4",
- "surefire-junit47",
- "surefire-testng",
- "surefire-junit-platform",
- "surefire-api",
- "surefire-logger-api",
- "surefire-shared-utils",
- "common-java5",
- "common-junit3",
- "common-junit4",
- "common-junit48",
- "common-testng-utils"
+ private static final String[][] PROVIDER_CLASSPATH_ORDER = {
+ // groupId, artifactId [, classifier]
+ {"org.apache.maven.surefire", "surefire-junit3"},
+ {"org.apache.maven.surefire", "surefire-junit4"},
+ {"org.apache.maven.surefire", "surefire-junit47"},
+ {"org.apache.maven.surefire", "surefire-testng"},
+ {"org.apache.maven.surefire", "surefire-junit-platform"},
+ {"org.apache.maven.surefire", "surefire-api"},
+ {"org.apache.maven.surefire", "surefire-logger-api"},
+ {"org.apache.maven.surefire", "surefire-shared-utils"},
+ {"org.apache.maven.surefire", "common-java5"},
+ {"org.apache.maven.surefire", "common-junit3"},
+ {"org.apache.maven.surefire", "common-junit4"},
+ {"org.apache.maven.surefire", "common-junit48"},
+ {"org.apache.maven.surefire", "common-testng-utils"}
Review comment:
Is it related to subject of PR?
##########
File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireDependencyResolver.java
##########
@@ -221,13 +223,18 @@ private ArtifactResolutionResult resolveArtifact( Artifact artifact, List<Artifa
private static Set<Artifact> orderProviderArtifacts( Set<Artifact> providerArtifacts )
{
Set<Artifact> orderedProviderArtifacts = new LinkedHashSet<>();
- for ( String order : PROVIDER_CLASSPATH_ORDER )
+ for ( String[] coordinates : PROVIDER_CLASSPATH_ORDER )
{
Iterator<Artifact> providerArtifactsIt = providerArtifacts.iterator();
while ( providerArtifactsIt.hasNext() )
{
+ String groupId = coordinates[0];
+ String artifactId = coordinates[1];
+ String classifier = coordinates.length == 3 ? coordinates[2] : null;
Review comment:
iterate by static `PROVIDER_CLASSPATH_ORDER`, I don't see items with classifier ...
##########
File path: surefire-shared-utils/pom.xml
##########
@@ -100,5 +102,35 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <!-- First, install the project without tests -> mvn install -DskipTests
+ This is a workaround for IntelliJ IDEA, see https://youtrack.jetbrains.com/issue/IDEA-148573
+ IDEA is able to recognize external artifacts with classifiers. But IDEA expects modules and their artifacts
+ without classifier. If the version differs from project, the idea would understand it as external artifact.
+ -->
+ <id>ide-development</id>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-install-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>install-devel-jar</id>
+ <phase>install</phase>
+ <goals>
+ <goal>install-file</goal>
+ </goals>
+ <configuration>
+ <artifactId>surefire-shared-utils</artifactId>
+ <version>3-SNAPSHOT</version>
Review comment:
I suppose that nobody will not install project with special profile ...
##########
File path: pom.xml
##########
@@ -687,7 +688,17 @@
</reporting>
<profiles>
-
+ <profile>
+ <!-- First, install the project without tests -> mvn install -DskipTests
+ This is a workaround for IntelliJ IDEA, see https://youtrack.jetbrains.com/issue/IDEA-148573
+ IDEA is able to recognize external artifacts with classifiers. But IDEA expects modules and their artifacts
+ without classifier. If the version differs from project, the idea would understand it as external artifact.
+ -->
+ <id>ide-development</id>
+ <properties>
+ <surefire-shared-utils.version>3-SNAPSHOT</surefire-shared-utils.version>
+ </properties>
+ </profile>
Review comment:
I suppose that nobody will not install project with special profile ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#issuecomment-1013490634
@michael-o
Good answer! So we should not have any blocker here, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#discussion_r786192814
##########
File path: maven-failsafe-plugin/pom.xml
##########
@@ -266,12 +266,12 @@
<postBuildHookScript>verify</postBuildHookScript>
<settingsFile>src/it/settings.xml</settingsFile>
<skipInvocation>${skipTests}</skipInvocation>
- <streamLogs>true</streamLogs>
<showErrors>true</showErrors>
<properties>
<integration-test-port>${failsafe-integration-test-port}</integration-test-port>
<integration-test-stop-port>${failsafe-integration-test-stop-port}</integration-test-stop-port>
</properties>
+ <debug>true</debug>
Review comment:
Sometimes I need to have debug logs if I investigate a problem. For instance failures of downloading artifacts of plugin parameters, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] michael-o commented on pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#issuecomment-1013487360
> @michael-o I hope the `maven-release-plugin` would not crash on this
>
> ```
> <surefire-shared-utils.version>${project.version}</surefire-shared-utils.version>
>
> <dependencies>
> <dependency>
> <groupId>org.apache.maven.surefire</groupId>
> <artifactId>surefire-shared-utils</artifactId>
> <version>${surefire-shared-utils.version}</version>
> <classifier>shaded</classifier>
> </dependency>
> </dependencies>
> ```
Why should it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#issuecomment-1013485123
@michael-o
I hope the `maven-release-plugin` would not crash on this
```
<surefire-shared-utils.version>${project.version}</surefire-shared-utils.version>
<dependencies>
<dependency>
<groupId>org.apache.maven.surefire</groupId>
<artifactId>surefire-shared-utils</artifactId>
<version>${project.version}</version>
<classifier>shaded</classifier>
</dependency>
</dependencies>
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 merged pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
Tibor17 merged pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#discussion_r786286365
##########
File path: surefire-booter/pom.xml
##########
@@ -115,11 +115,12 @@
</plugin>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
+ <version>3.0.0-M3</version>
Review comment:
@eolivelli
I have used the 2.22.2 but it gives me bad result
`[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0`
Sorry!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#issuecomment-1013993635
@michael-o
I don't want to install and deploy the original POM. I want to have `dependency-reduced-pom.xml` after shading. So the classifier is attached but I do not want to have the original jar and POM because the dependencies affected already the ITs, the dependencies must not present in the POM any more. How can we do that? The shade plugin does not have this option, I think, so should we do it on the install/deploy level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#discussion_r786202256
##########
File path: surefire-shared-utils/pom.xml
##########
@@ -100,5 +102,35 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <!-- First, install the project without tests -> mvn install -DskipTests
+ This is a workaround for IntelliJ IDEA, see https://youtrack.jetbrains.com/issue/IDEA-148573
+ IDEA is able to recognize external artifacts with classifiers. But IDEA expects modules and their artifacts
+ without classifier. If the version differs from project, the idea would understand it as external artifact.
+ -->
+ <id>ide-development</id>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-install-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>install-devel-jar</id>
+ <phase>install</phase>
+ <goals>
+ <goal>install-file</goal>
+ </goals>
+ <configuration>
+ <artifactId>surefire-shared-utils</artifactId>
+ <version>3-SNAPSHOT</version>
Review comment:
@eoliveli I can change this number. Let me know pls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] michael-o commented on pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#issuecomment-1013494133
Likely not. Let see what happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#discussion_r786278628
##########
File path: pom.xml
##########
@@ -687,7 +688,17 @@
</reporting>
<profiles>
-
+ <profile>
+ <!-- First, install the project without tests -> mvn install -DskipTests
+ This is a workaround for IntelliJ IDEA, see https://youtrack.jetbrains.com/issue/IDEA-148573
+ IDEA is able to recognize external artifacts with classifiers. But IDEA expects modules and their artifacts
+ without classifier. If the version differs from project, the idea would understand it as external artifact.
+ -->
+ <id>ide-development</id>
+ <properties>
+ <surefire-shared-utils.version>3-SNAPSHOT</surefire-shared-utils.version>
+ </properties>
+ </profile>
Review comment:
@slawekjaranowski
Slawomir, we were talking about it in previous PR. There is no other way. I was explaining it that the IDE and Maven work different way, the Maven understands shading and attaching artifacts but the IDEs don't and that's the reason why it has to be like this. We don't live in ideal world but we cannot wait forever until Jetbrain would fix the issue. If the developers does not care about red line, okay, but I don't because I do not want to have red lines in the code and also I do not want to copy paste the source code from external libraries because it is not maintainable way. So this is the explanation. Regarding the version 3-SNAPSHOT, it can be anything, that's only cosmetic issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#discussion_r786201450
##########
File path: surefire-shared-utils/pom.xml
##########
@@ -100,5 +102,35 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <!-- First, install the project without tests -> mvn install -DskipTests
+ This is a workaround for IntelliJ IDEA, see https://youtrack.jetbrains.com/issue/IDEA-148573
+ IDEA is able to recognize external artifacts with classifiers. But IDEA expects modules and their artifacts
+ without classifier. If the version differs from project, the idea would understand it as external artifact.
+ -->
+ <id>ide-development</id>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-install-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>install-devel-jar</id>
+ <phase>install</phase>
+ <goals>
+ <goal>install-file</goal>
+ </goals>
+ <configuration>
+ <artifactId>surefire-shared-utils</artifactId>
+ <version>3-SNAPSHOT</version>
Review comment:
Because this version is not used in deployment or elsewhere. Basically the number also does not matter ;-)
The only reason why this section is here is the fact that Intellij IDEA and maybe Eclipse too, is not able to work with Shaded Jar in module `surefire-shared-utils`. So the IDEA is not able to load the shaded jar even if Maven attached it to the POM. So this is only the trick that we can enable this profile `ide-development` and identical Jar is loaded by IDEA from local repo and then we do not have the red lines in the code. Of course Maven build does not need it because Maven can work with shaded and attached Jar. But IDEA has this problem, pity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#discussion_r786194557
##########
File path: surefire-booter/pom.xml
##########
@@ -115,11 +115,12 @@
</plugin>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
+ <version>3.0.0-M3</version>
Review comment:
I can try with 2.22.2. Let's see what happens...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] eolivelli commented on a change in pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#discussion_r786163443
##########
File path: maven-failsafe-plugin/pom.xml
##########
@@ -266,12 +266,12 @@
<postBuildHookScript>verify</postBuildHookScript>
<settingsFile>src/it/settings.xml</settingsFile>
<skipInvocation>${skipTests}</skipInvocation>
- <streamLogs>true</streamLogs>
<showErrors>true</showErrors>
<properties>
<integration-test-port>${failsafe-integration-test-port}</integration-test-port>
<integration-test-stop-port>${failsafe-integration-test-stop-port}</integration-test-stop-port>
</properties>
+ <debug>true</debug>
Review comment:
is this needed ?
##########
File path: surefire-booter/pom.xml
##########
@@ -115,11 +115,12 @@
</plugin>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
+ <version>3.0.0-M3</version>
Review comment:
why are we using this older version "3.0.0-M3" ? what's the reasoning about choosing this one ? could it be 2.x ?
##########
File path: surefire-shared-utils/pom.xml
##########
@@ -100,5 +102,35 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <!-- First, install the project without tests -> mvn install -DskipTests
+ This is a workaround for IntelliJ IDEA, see https://youtrack.jetbrains.com/issue/IDEA-148573
+ IDEA is able to recognize external artifacts with classifiers. But IDEA expects modules and their artifacts
+ without classifier. If the version differs from project, the idea would understand it as external artifact.
+ -->
+ <id>ide-development</id>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-install-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>install-devel-jar</id>
+ <phase>install</phase>
+ <goals>
+ <goal>install-file</goal>
+ </goals>
+ <configuration>
+ <artifactId>surefire-shared-utils</artifactId>
+ <version>3-SNAPSHOT</version>
Review comment:
why 3-SNAPSHOT ? is this a random name ?
##########
File path: maven-failsafe-plugin/pom.xml
##########
@@ -266,12 +266,12 @@
<postBuildHookScript>verify</postBuildHookScript>
<settingsFile>src/it/settings.xml</settingsFile>
<skipInvocation>${skipTests}</skipInvocation>
- <streamLogs>true</streamLogs>
Review comment:
why are we changing this line ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#issuecomment-1014873685
@slawekjaranowski
Slawomir, you probably really do not understand why it is here.
It was here since the beginning but you do not know the history.
The reason behind it is the fact that the external libraries also use Maven and we use ourselves in the internal tests. This is nothing wrong and nothing atypical in Maven. It avoids conflicts on the classpath, and as I said before, it was here always even before me, and it had the purpose. We live in real world and maven-shade-plugin is used in Maven with purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#discussion_r786287787
##########
File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireDependencyResolver.java
##########
@@ -61,20 +62,21 @@
{
static final String PROVIDER_GROUP_ID = "org.apache.maven.surefire";
- private static final String[] PROVIDER_CLASSPATH_ORDER = {
- "surefire-junit3",
- "surefire-junit4",
- "surefire-junit47",
- "surefire-testng",
- "surefire-junit-platform",
- "surefire-api",
- "surefire-logger-api",
- "surefire-shared-utils",
- "common-java5",
- "common-junit3",
- "common-junit4",
- "common-junit48",
- "common-testng-utils"
+ private static final String[][] PROVIDER_CLASSPATH_ORDER = {
+ // groupId, artifactId [, classifier]
+ {"org.apache.maven.surefire", "surefire-junit3"},
+ {"org.apache.maven.surefire", "surefire-junit4"},
+ {"org.apache.maven.surefire", "surefire-junit47"},
+ {"org.apache.maven.surefire", "surefire-testng"},
+ {"org.apache.maven.surefire", "surefire-junit-platform"},
+ {"org.apache.maven.surefire", "surefire-api"},
+ {"org.apache.maven.surefire", "surefire-logger-api"},
+ {"org.apache.maven.surefire", "surefire-shared-utils"},
+ {"org.apache.maven.surefire", "common-java5"},
+ {"org.apache.maven.surefire", "common-junit3"},
+ {"org.apache.maven.surefire", "common-junit4"},
+ {"org.apache.maven.surefire", "common-junit48"},
+ {"org.apache.maven.surefire", "common-testng-utils"}
Review comment:
yes, I know, this was related to the thinking process with classifier.
Let me pls squash the commits, it's easier to avoid changing this class afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#issuecomment-1013962213
In here I found out that the class path contains other artifacts however the shadefire does not have any transitive dependencies. So, we will verify it and fix it separately.
Currently, the internal surefire and failsafe plugins, which are used for internal testing purposes, should use the old version `3.0.0-M3`. The reason is that M3 does not have `surefire-shared-utils` and the later versions have it but the artifact is not shaded in `surefire-shadefire` and therefore may produce conflicts in the class path if M4+ is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #443: [SUREFIRE-1972] Use current version of surefire-shared-utils
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #443:
URL: https://github.com/apache/maven-surefire/pull/443#issuecomment-1013993635
@michael-o
I don't want to install and deploy the original POM. I want to have `dependency-reduced-pom.xml` after shading. So the classifier is attached but I do not want to have the original jar and POM because the dependencies affected already the ITs, the dependencies must not present in the POM any more. How can we do that? The shade plugin does not have this option, I think, so should be do it on the install/deploy level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org