You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/16 13:49:12 UTC

[GitHub] [flink] NicoK opened a new pull request, #21335: [FLINK-30045][flink-clients] fix too eager check for main class existence

NicoK opened a new pull request, #21335:
URL: https://github.com/apache/flink/pull/21335

   ## What is the purpose of the change
   
   Remove a too eager main class check in `StandaloneApplicationClusterEntryPoint` (this is already covered by `PackagedProgram`).
   
   ## Brief change log
   
   - remove main class check from `FromClasspathEntryClassInformationProvider` 
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as `DefaultPackagedProgramRetrieverTest` which I adapted to get the `PackagedProgram` and fail through that since this is what an EntryPoint has to do.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #21335: [FLINK-30045][flink-clients] fix too eager check for main class existence

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #21335:
URL: https://github.com/apache/flink/pull/21335#issuecomment-1317332532

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21335: [FLINK-30045][flink-clients] fix too eager check for main class existence

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21335:
URL: https://github.com/apache/flink/pull/21335#issuecomment-1317070913

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "08e41023fcb314ce5e5d31f01984a845d765bba9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "08e41023fcb314ce5e5d31f01984a845d765bba9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 08e41023fcb314ce5e5d31f01984a845d765bba9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #21335: [FLINK-30045][flink-clients] fix too eager check for main class existence

Posted by GitBox <gi...@apache.org>.
zentol merged PR #21335:
URL: https://github.com/apache/flink/pull/21335


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org