You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/14 23:05:34 UTC
[GitHub] [flink] rkhachatryan opened a new pull request #14073: [FLINK-20145][task] Don't expose modifiable PrioritizedDeque.iterator
rkhachatryan opened a new pull request #14073:
URL: https://github.com/apache/flink/pull/14073
## What is the purpose of the change
Don't expose modifiable PrioritizedDeque.iterator to prevent inconsistency between `numPriorityElements` and `deque`.
## Verifying this change
This change is a trivial rework without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14073: [FLINK-20145][task] Don't expose modifiable PrioritizedDeque.iterator
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14073:
URL: https://github.com/apache/flink/pull/14073#issuecomment-727280506
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "399fbe50a7f2e1e09525bc24e41b50eda8b59e55",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "399fbe50a7f2e1e09525bc24e41b50eda8b59e55",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 399fbe50a7f2e1e09525bc24e41b50eda8b59e55 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14073: [FLINK-20145][task] Don't expose modifiable PrioritizedDeque.iterator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14073:
URL: https://github.com/apache/flink/pull/14073#issuecomment-727280506
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "399fbe50a7f2e1e09525bc24e41b50eda8b59e55",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9590",
"triggerID" : "399fbe50a7f2e1e09525bc24e41b50eda8b59e55",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 399fbe50a7f2e1e09525bc24e41b50eda8b59e55 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9590)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14073: [FLINK-20145][task] Don't expose modifiable PrioritizedDeque.iterator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14073:
URL: https://github.com/apache/flink/pull/14073#issuecomment-727280506
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "399fbe50a7f2e1e09525bc24e41b50eda8b59e55",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9590",
"triggerID" : "399fbe50a7f2e1e09525bc24e41b50eda8b59e55",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 399fbe50a7f2e1e09525bc24e41b50eda8b59e55 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9590)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #14073: [FLINK-20145][task] Don't expose modifiable PrioritizedDeque.iterator
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #14073:
URL: https://github.com/apache/flink/pull/14073#issuecomment-727789160
I'm merging but not closing the ticket as I couldn't confirm yet, if it's indeed causing the issue. (It's only valid for union gates).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14073: [FLINK-20145][task] Don't expose modifiable PrioritizedDeque.iterator
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14073:
URL: https://github.com/apache/flink/pull/14073#issuecomment-727278544
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 19c6a551fa8a775d064e00cc17548a24baf15150 (Sat Nov 14 23:08:06 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #14073: [FLINK-20145][task] Don't expose modifiable PrioritizedDeque.iterator
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #14073:
URL: https://github.com/apache/flink/pull/14073#issuecomment-727525870
AZP build failed because of FLINK-20149
```
*2020-11-15T03:22:38.3437135Z Nov 15 03:22:38 [ERROR] Failures:
2020-11-15T03:22:38.3438208Z Nov 15 03:22:38 [ERROR] SQLClientKafkaITCase.testKafka:166->checkCsvResultFile:226 Did not get expected results before timeout.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise merged pull request #14073: [FLINK-20145][task] Don't expose modifiable PrioritizedDeque.iterator
Posted by GitBox <gi...@apache.org>.
AHeise merged pull request #14073:
URL: https://github.com/apache/flink/pull/14073
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org