You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2016/11/13 16:31:59 UTC
[jira] [Commented] (CB-9274) InAppBrowser compile error for Amazon
FireOS
[ https://issues.apache.org/jira/browse/CB-9274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15661729#comment-15661729 ]
ASF subversion and git services commented on CB-9274:
-----------------------------------------------------
Commit 5cbbc8e26ee6f9231b319229eaf75d5e008d5e64 in cordova-plugin-inappbrowser's branch refs/heads/master from ipaterson
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=5cbbc8e ]
CB-9274 Adds missing methods to InAppBrowser to allow compilation for Amazon FireOS.
This closes #107
> InAppBrowser compile error for Amazon FireOS
> --------------------------------------------
>
> Key: CB-9274
> URL: https://issues.apache.org/jira/browse/CB-9274
> Project: Apache Cordova
> Issue Type: Bug
> Components: Amazon FireOS (deprecated), Plugin InAppBrowser
> Affects Versions: 3.5.0
> Reporter: Ian Paterson
> Assignee: jcesarmobile
> Labels: FireOS, compile-error, patch
>
> Attempting to compile the InAppBrowser plugin for Amazon FireOS fails due to the following programming errors:
> {noformat}
> [javac] Compiling 8 source files to /path/to/amazon-fireos/ant-build/classes
> [javac] /path/to/amazon-fireos/src/org/apache/cordova/inappbrowser/InAppBrowserDialog.java:51: cannot find symbol
> [javac] symbol : method hardwareBack()
> [javac] location: class org.apache.cordova.inappbrowser.InAppBrowser
> [javac] if (this.inAppBrowser.hardwareBack() && this.inAppBrowser.canGoBack()) {
> [javac] ^
> [javac] /path/to/amazon-fireos/src/org/apache/cordova/inappbrowser/InAppBrowserDialog.java:51: cannot find symbol
> [javac] symbol : method canGoBack()
> [javac] location: class org.apache.cordova.inappbrowser.InAppBrowser
> [javac] if (this.inAppBrowser.hardwareBack() && this.inAppBrowser.canGoBack()) {
> [javac] ^
> [javac] /path/to/amazon-fireos/src/org/apache/cordova/inappbrowser/InAppBrowserDialog.java:52: goBack() has private access in org.apache.cordova.inappbrowser.InAppBrowser
> [javac] this.inAppBrowser.goBack();
> [javac] ^
> [javac] Note: /path/to/amazon-fireos/src/org/apache/cordova/inappbrowser/InAppBrowser.java uses or overrides a deprecated API.
> [javac] Note: Recompile with -Xlint:deprecation for details.
> [javac] 3 errors
> {noformat}
> As best I can determine, this problem has existed since plugin version 0.5.2 and was introduced on August 14 in [commit 69ca780772b406ab02ec1bd1a8e4dca70052e926|https://github.com/apache/cordova-plugin-inappbrowser/commit/69ca780772b406ab02ec1bd1a8e4dca70052e926]. Previous commits had diverged the implementation of InAppBrowser.java in Amazon FireOS such that it was no longer compatible with the InAppBrowser.java for Android.
> I am preparing a pull request to patch this issue to restore the ability to use the plugin on this platform.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org