[GitHub] [incubator-opendal] weihanglo commented on pull request #1361: ci: Pin time <= 0.3.17 until we decide to bump MSRV

["weihanglo (via GitHub)" <gi...@apache.org>]

weihanglo commented on PR #1361:
URL: https://github.com/apache/incubator-opendal/pull/1361#issuecomment-1470178676

   Hello. I am a bit curious about the rationale of pinning the version here. Since we commit Cargo.lock into opendal's git history, we get the full control of what version we want. We are not necessary to lock downstream user only because our MSRV policy does meet time's.
   
   It might be inconvient when running `cargo update` and accidentally getting its version updated. However, we already enforce the rule in [the CI pipeline](https://github.com/apache/incubator-opendal/blob/5550b9f93fccd43781c65a6b2aa59817e124b1be/.github/workflows/ci.yml#L81C8-L82) so that should sneak into main branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org