[GitHub] [ozone] captainzmc commented on a change in pull request #2782: HDDS-5763. Set raft.server.data-stream.async.write.thread.pool.size conf in datanode.

[GitBox <gi...@apache.org>]

captainzmc commented on a change in pull request #2782:
URL: https://github.com/apache/ozone/pull/2782#discussion_r738895554



##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java
##########
@@ -249,6 +249,11 @@ private void setUpRatisStream(RaftProperties properties) {
             .getClientPoolSize();
     RaftServerConfigKeys.DataStream.setClientPoolSize(properties,
         dataStreamClientPoolSize);
+    final int asyncWriteThreadPoolPoolSize =
+        conf.getObject(DatanodeRatisServerConfig.class)
+            .getAsyncWriteThreadPoolPoolSize();
+    RaftServerConfigKeys.DataStream.setAsyncWriteThreadPoolSize(properties,
+        asyncWriteThreadPoolPoolSize);

Review comment:
       This property is already set on line 245, so it not need set here.

##########
File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/conf/DatanodeRatisServerConfig.java
##########
@@ -175,6 +175,22 @@ public void setClientPoolSize(int clientPoolSize) {
     this.clientPoolSize = clientPoolSize;
   }
 
+  @Config(key = "datastream.async.write.thread.pool.size",

Review comment:
       In the previous implementation we added datastream.write.threads, so we just need to reuse the previous key.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org