You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/29 09:47:20 UTC
[jira] [Commented] (APEXMALHAR-2172) Update JDBC poll input
operator to fix issues
[ https://issues.apache.org/jira/browse/APEXMALHAR-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399052#comment-15399052 ]
ASF GitHub Bot commented on APEXMALHAR-2172:
--------------------------------------------
GitHub user DT-Priyanka opened a pull request:
https://github.com/apache/apex-malhar/pull/355
[review only]APEXMALHAR-2172: Updates to JDBC Poll Input Operator
Changes include:
1. Using jooq query to construct sql queries
2. Update logic to query based on row numbers instead of primary key column values
3. Small fixes
4. Code refactoring to make it more readable
5. Update to test cases, to abstract out generic test code and add more tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DT-Priyanka/incubator-apex-malhar APEXMALHAR-2172-jdbc-poller-input
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/apex-malhar/pull/355.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #355
----
commit 47a692c7382795f88e4ce7a2ca640b70b2aa0094
Author: Priyanka Gugale <pr...@datatorrent.com>
Date: 2016-07-19T06:40:08Z
APEXMALHAR-2172: Updates to JDBC Poll Input Operator
----
> Update JDBC poll input operator to fix issues
> ---------------------------------------------
>
> Key: APEXMALHAR-2172
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2172
> Project: Apache Apex Malhar
> Issue Type: Improvement
> Reporter: Priyanka Gugale
> Assignee: Priyanka Gugale
>
> Update JDBCPollInputOperator to:
> 1. Fix small bugs
> 2. Use jooq query dsl library to construct sql queries
> 3. Make code more readable
> 4. Use row counts rather than key column values to partition reads
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)