You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/04/26 06:41:23 UTC

[GitHub] [zookeeper] XavierChengZW opened a new pull request #1337: optimized code,static field be directly referred by its class name

XavierChengZW opened a new pull request #1337:
URL: https://github.com/apache/zookeeper/pull/1337


   optimized code,A static field should be directly referred by its class name


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] eolivelli commented on pull request #1337: optimized code,static field be directly referred by its class name

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1337:
URL: https://github.com/apache/zookeeper/pull/1337#issuecomment-620237972


   Looks good.
   Can you please open a JIRA and cite the jira ticket id on the commit message? Then we are good to commit this patch.
   
   Personally I don't think this is really an 'optimized' version of the code but now the code looks cleaner. We should check the actual byte code emitted by javac
   
   It is strange that spotbugs did not quarrel about these accesses to static variables.
   Did we put some FBSuppressWarning directive?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] XavierChengZW commented on pull request #1337: ZOOKEEPER-3811 : cleaning up code,static field be directly referred by its class name

Posted by GitBox <gi...@apache.org>.
XavierChengZW commented on pull request #1337:
URL: https://github.com/apache/zookeeper/pull/1337#issuecomment-620544973


   > Looks good.
   > Can you please open a JIRA and cite the jira ticket id on the commit message? Then we are good to commit this patch.
   > 
   > Personally I don't think this is really an 'optimized' version of the code but now the code looks cleaner. We should check the actual byte code emitted by javac
   > 
   > It is strange that spotbugs did not quarrel about these accesses to static variables.
   > Did we put some FBSuppressWarning directive?
   
   Yeah 
   
   > Looks good.
   > Can you please open a JIRA and cite the jira ticket id on the commit message? Then we are good to commit this patch.
   > 
   > Personally I don't think this is really an 'optimized' version of the code but now the code looks cleaner. We should check the actual byte code emitted by javac
   > 
   > It is strange that spotbugs did not quarrel about these accesses to static variables.
   > Did we put some FBSuppressWarning directive?
   
   OK, I've added a JIRA and changed the title description.  When you are in spotbugs, you can use a variety of code specification plug-ins to scan, which will have a good effect


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] symat commented on pull request #1337: ZOOKEEPER-3811 : cleaning up code,static field be directly referred by its class name

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1337:
URL: https://github.com/apache/zookeeper/pull/1337#issuecomment-621977437


   merged, thanks for caring about ZooKeeper code! :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] XavierChengZW edited a comment on pull request #1337: ZOOKEEPER-3811 : cleaning up code,static field be directly referred by its class name

Posted by GitBox <gi...@apache.org>.
XavierChengZW edited a comment on pull request #1337:
URL: https://github.com/apache/zookeeper/pull/1337#issuecomment-620544973


   > Looks good.
   > Can you please open a JIRA and cite the jira ticket id on the commit message? Then we are good to commit this patch.
   > 
   > Personally I don't think this is really an 'optimized' version of the code but now the code looks cleaner. We should check the actual byte code emitted by javac
   > 
   > It is strange that spotbugs did not quarrel about these accesses to static variables.
   > Did we put some FBSuppressWarning directive?
   
   OK, I've added a JIRA and changed the title description.  When you are in spotbugs, you can use a variety of code specification plug-ins to scan, which will have a good effect


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] symat commented on pull request #1337: ZOOKEEPER-3811 : cleaning up code,static field be directly referred by its class name

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1337:
URL: https://github.com/apache/zookeeper/pull/1337#issuecomment-621970575


   I would also though that this should have been caught by spotbugs. At least IntellJ usually remind me to these things :)
   
   I'll merge it to master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org