You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/02/07 05:56:43 UTC

[GitHub] [hbase] bharathv commented on a change in pull request #1110: HBASE-23761: The new cache entry can overflow the maxSize in CachedEn…

bharathv commented on a change in pull request #1110: HBASE-23761: The new cache entry can overflow the maxSize in CachedEn…
URL: https://github.com/apache/hbase/pull/1110#discussion_r376200409
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruCachedBlockQueue.java
 ##########
 @@ -65,14 +65,15 @@ public LruCachedBlockQueue(long maxSize, long blockSize) {
    * @param cb block to try to add to the queue
    */
   public void add(LruCachedBlock cb) {
 
 Review comment:
   That should be a separate change and is probably more involved ..just making it synchronized affects performance since that serializes all the invocations. (I'm not too familiar with that area of code on top of my head to explain the implications correctly, need to study it a little bit).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services