You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by db...@apache.org on 2019/08/05 18:06:26 UTC

[tomee] branch master updated: Temporarily disabling TOMEE-2517 Bean Validation with MicroProfile JWT

This is an automated email from the ASF dual-hosted git repository.

dblevins pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomee.git


The following commit(s) were added to refs/heads/master by this push:
     new d40d9e4  Temporarily disabling TOMEE-2517 Bean Validation with MicroProfile JWT
d40d9e4 is described below

commit d40d9e45057b957ae26339d30e79523f9d8ee86b
Author: David Blevins <da...@gmail.com>
AuthorDate: Mon Aug 5 11:06:08 2019 -0700

    Temporarily disabling TOMEE-2517 Bean Validation with MicroProfile JWT
---
 examples/mp-jwt-bean-validation-strongly-typed/README.adoc          | 2 ++
 examples/mp-jwt-bean-validation/README.adoc                         | 2 ++
 examples/pom.xml                                                    | 3 +++
 .../tomee/microprofile/jwt/bval/ValidationInterceptorsFeature.java  | 6 ++++++
 pom.xml                                                             | 2 +-
 5 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/examples/mp-jwt-bean-validation-strongly-typed/README.adoc b/examples/mp-jwt-bean-validation-strongly-typed/README.adoc
index b2a2dfd..735afac 100644
--- a/examples/mp-jwt-bean-validation-strongly-typed/README.adoc
+++ b/examples/mp-jwt-bean-validation-strongly-typed/README.adoc
@@ -5,3 +5,5 @@
 = MicroProfile JWT, Bean Validation and Strongly-Typed Annotations
 
 TODO
+
+CAUTION: This feature has been temporarily removed in `master` and needs to be reworked.  It is anticipated this will complete before Apache TomEE 8.0.0 final.
diff --git a/examples/mp-jwt-bean-validation/README.adoc b/examples/mp-jwt-bean-validation/README.adoc
index 86fdadf..8973b60 100644
--- a/examples/mp-jwt-bean-validation/README.adoc
+++ b/examples/mp-jwt-bean-validation/README.adoc
@@ -6,6 +6,8 @@
 
 TomEE has a fun feature that allows the use of Bean Validation as an alternative or compliment to the `@RolesAllowed` annotation.  The motivation of the feature is that `JsonWebToken` is effectively a bean and a security check is ultimately an act of producing a boolean result using some minimal input.  It is a perfect problem for Bean Validation.
 
+CAUTION: This feature has been temporarily removed in `master` and needs to be reworked.  It is anticipated this will complete before Apache TomEE 8.0.0 final.
+
 The feature ultimately allows you to implement a method like this:
 
 [source,java]
diff --git a/examples/pom.xml b/examples/pom.xml
index f739dc1..e30dcb8 100644
--- a/examples/pom.xml
+++ b/examples/pom.xml
@@ -110,8 +110,11 @@
     <module>mp-config-source-database</module>
     <module>mp-faulttolerance-fallback</module>
     <module>mp-faulttolerance-retry</module>
+    <!--
+    Momentarily cut out till the feature can be re-implemented
     <module>mp-jwt-bean-validation</module>
     <module>mp-jwt-bean-validation-strongly-typed</module>
+    -->
     <module>mp-metrics-counted</module>
     <module>mp-metrics-histogram</module>
     <module>mp-metrics-timed</module>
diff --git a/mp-jwt/src/main/java/org/apache/tomee/microprofile/jwt/bval/ValidationInterceptorsFeature.java b/mp-jwt/src/main/java/org/apache/tomee/microprofile/jwt/bval/ValidationInterceptorsFeature.java
index f2a09ba..2bfeb8a 100644
--- a/mp-jwt/src/main/java/org/apache/tomee/microprofile/jwt/bval/ValidationInterceptorsFeature.java
+++ b/mp-jwt/src/main/java/org/apache/tomee/microprofile/jwt/bval/ValidationInterceptorsFeature.java
@@ -26,6 +26,12 @@ public class ValidationInterceptorsFeature implements DynamicFeature {
 
     @Override
     public void configure(final ResourceInfo resourceInfo, final FeatureContext context) {
+        /**
+         * Temporarily disable this feature till we are post BVal 2.0.2 upgrade
+         */
+    }
+
+    private void disabled(final ResourceInfo resourceInfo, final FeatureContext context) {
 
         final Class<?> resourceClass = resourceInfo.getResourceClass();
 
diff --git a/pom.xml b/pom.xml
index 202a1b9..5e7766b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -170,7 +170,7 @@
     <commons-io.version>2.4</commons-io.version>
     <commons-net.version>3.3</commons-net.version>
 
-    <bval.version>2.0.2-69c36fa8-1-SNAPSHOT</bval.version>
+    <bval.version>2.0.1</bval.version>
     <org.apache.activemq.version>5.15.6</org.apache.activemq.version>
     <org.springframework.version>3.1.4.RELEASE</org.springframework.version>
     <junit.version>4.12</junit.version>