You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by egorklimov <gi...@git.apache.org> on 2018/08/16 14:09:01 UTC
[GitHub] zeppelin pull request #3148: [ZEPPELIN-3715] Fix text & titile passing in No...
GitHub user egorklimov opened a pull request:
https://github.com/apache/zeppelin/pull/3148
[ZEPPELIN-3715] Fix text & titile passing in NotebookRestApi.runParagraph
### What is this PR for?
All paragraphs processing as blank, because text string is empty.
```
@POST
@Path("job/{noteId}/{paragraphId}")
@ZeppelinApi
public Response runParagraph(@PathParam("noteId") String noteId,
@PathParam("paragraphId") String paragraphId, String message)
throws IOException, IllegalArgumentException {
...
notebookService.runParagraph(
noteId, paragraphId, "", "", params,
new HashMap<String, Object>(), false, getServiceContext(), new RestServiceCallback<>());
return new JsonResponse<>(Status.OK).build();
}
```
### What type of PR is it?
Bug Fix
### What is the Jira issue?
* [issue](https://issues.apache.org/jira/browse/ZEPPELIN-3715)
### How should this be tested?
* [CI pass](https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/416706975)
* Test updated
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3715
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3148.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3148
----
commit 9e9f3267d113859d0c47ce46371726105dd5a99c
Author: egorklimov <kl...@...>
Date: 2018-08-15T10:05:07Z
NotebookRestApi fixed
----
---
[GitHub] zeppelin pull request #3148: [ZEPPELIN-3715] Fix text & titile passing in No...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3148
---
[GitHub] zeppelin issue #3148: [ZEPPELIN-3715] Fix text & titile passing in NotebookR...
Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov commented on the issue:
https://github.com/apache/zeppelin/pull/3148
CI pass: https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/422448244
---
[GitHub] zeppelin issue #3148: [ZEPPELIN-3715] Fix text & titile passing in NotebookR...
Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov commented on the issue:
https://github.com/apache/zeppelin/pull/3148
@zjffdu Seems that this PR can be merged, look, please
---