[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1352: HDDS-4147. Add OFS to FileSystem META-INF

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #1352:
URL: https://github.com/apache/hadoop-ozone/pull/1352#discussion_r477384579



##########
File path: hadoop-ozone/dist/src/main/compose/ozone-om-ha/docker-config
##########
@@ -14,8 +14,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-CORE-SITE.XML_fs.o3fs.impl=org.apache.hadoop.fs.ozone.OzoneFileSystem
-CORE-SITE.XML_fs.defaultFS=o3fs://bucket1.volume1.omservice
+CORE-SITE.XML_fs.defaultFS=ofs://omservice

Review comment:
       I think only MR tests (`ozone-mr` and `ozonesecure-mr`) use `defaultFS` when setting up MR environment:
   
   https://github.com/apache/hadoop-ozone/blob/8102ac799816f417e096873b6f351fd531f7bfbf/hadoop-ozone/dist/src/main/smoketest/createmrenv.robot#L46-L47
   
   Changing `defaultFS` to `ofs://` in these environments can help validate the META-INF changes.
   
   Changing/adding `defaultFS` in the other ones is not needed IMO.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org