You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/11/12 15:46:54 UTC

[kudu-CR](branch-1.11.x) docs: additional instructions for installing memkind from source 

Hello Kudu Jenkins,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/14696

to review the following change.


Change subject: docs: additional instructions for installing memkind from source
......................................................................

docs: additional instructions for installing memkind from source

This is often necessary as most of our supported distros include a memkind
that's too old. There are some complications, however:
- Using the default prefix (/usr/local) means Kudu won't find the library.
- Even after installing to /usr, ldconfig must be run to regenerate the
  cache of dynamic libraries in "trusted locations" like /usr/lib.

Change-Id: I7d52d02ad87a27e5fef5ba5c0ab8932128a29762
Reviewed-on: http://gerrit.cloudera.org:8080/14683
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit b97c2f6ca78097186c3c77e759cf43bab966cc7b)
  Conflicts:
    docs/installation.adoc
---
M docs/installation.adoc
M src/kudu/cfile/block_cache.cc
2 files changed, 61 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/14696/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d52d02ad87a27e5fef5ba5c0ab8932128a29762
Gerrit-Change-Number: 14696
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.11.x) docs: additional instructions for installing memkind from source

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14696 )

Change subject: docs: additional instructions for installing memkind from source
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d52d02ad87a27e5fef5ba5c0ab8932128a29762
Gerrit-Change-Number: 14696
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 12 Nov 2019 16:06:33 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.11.x) docs: additional instructions for installing memkind from source

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14696 )

Change subject: docs: additional instructions for installing memkind from source
......................................................................

docs: additional instructions for installing memkind from source

This is often necessary as most of our supported distros include a memkind
that's too old. There are some complications, however:
- Using the default prefix (/usr/local) means Kudu won't find the library.
- Even after installing to /usr, ldconfig must be run to regenerate the
  cache of dynamic libraries in "trusted locations" like /usr/lib.

Change-Id: I7d52d02ad87a27e5fef5ba5c0ab8932128a29762
Reviewed-on: http://gerrit.cloudera.org:8080/14683
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit b97c2f6ca78097186c3c77e759cf43bab966cc7b)
  Conflicts:
    docs/installation.adoc
Reviewed-on: http://gerrit.cloudera.org:8080/14696
Reviewed-by: Grant Henke <gr...@apache.org>
---
M docs/installation.adoc
M src/kudu/cfile/block_cache.cc
2 files changed, 61 insertions(+), 1 deletion(-)

Approvals:
  Grant Henke: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d52d02ad87a27e5fef5ba5c0ab8932128a29762
Gerrit-Change-Number: 14696
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)