You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/07/13 13:24:40 UTC
[GitHub] [kafka] serjchebotarev opened a new pull request #9014: KAFKA-10156 [WIP] Fix flaky testCloseOldestConnection
serjchebotarev opened a new pull request #9014:
URL: https://github.com/apache/kafka/pull/9014
In `testCloseOldestConnection` flaky behavior can be caused by the code path when in `selector.poll(0)` the connection is not closed immediately. This can be due to `Selector#maybeReadFromClosingChannel` returning `true`. To avoid this, also check `selector.closingChannel(id)` in addition to `selector.disconnected().containsKey(id)`.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9014: KAFKA-10156 [WIP] Fix flaky testCloseOldestConnection
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9014:
URL: https://github.com/apache/kafka/pull/9014#issuecomment-658032208
> This can be due to Selector#maybeReadFromClosingChannel returning true
Is it an issue in this case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] serjchebotarev commented on pull request #9014: KAFKA-10156 [WIP] Fix flaky testCloseOldestConnection
Posted by GitBox <gi...@apache.org>.
serjchebotarev commented on pull request #9014:
URL: https://github.com/apache/kafka/pull/9014#issuecomment-658137186
The problem is that locally I was not able to reproduce this behavior, AFAIK it was only observed in some CI builds. Maybe the way to check this is to implement fix and observe the test behavior in several CI builds... At the moment I do not have any better idea on how to check this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] serjchebotarev commented on pull request #9014: KAFKA-10156 [WIP] Fix flaky testCloseOldestConnection
Posted by GitBox <gi...@apache.org>.
serjchebotarev commented on pull request #9014:
URL: https://github.com/apache/kafka/pull/9014#issuecomment-658007924
@chia7712, @hachikuji & @ijuma could you please have a look at this one - if the chosen approach is okay or should this be done some other way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org