You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "yugan95 (via GitHub)" <gi...@apache.org> on 2026/08/10 11:34:53 UTC

[PR] [CELEBORN-2416] Export the C ABI from libceleborn_client.so by dropping --exclude-libs,ALL [celeborn]

yugan95 opened a new pull request, #3794:
URL: https://github.com/apache/celeborn/pull/3794

   
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR resolve a correctness bug?
   
   <!-- Check if yes. The `correctness` label will be added/removed automatically. -->
   - [ ] Yes
   
   ### Does this PR introduce _any_ user-facing change?
   
   <!-- Check if yes. -->
   - [ ] Yes
   
   
   ### How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2416] Export the C ABI from libceleborn_client.so by dropping --exclude-libs,ALL [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #3794: [CELEBORN-2416] Export the C ABI from libceleborn_client.so by dropping --exclude-libs,ALL
URL: https://github.com/apache/celeborn/pull/3794


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2416] Export the C ABI from libceleborn_client.so by dropping --exclude-libs,ALL [celeborn]

Posted by "yugan95 (via GitHub)" <gi...@apache.org>.
yugan95 commented on code in PR #3794:
URL: https://github.com/apache/celeborn/pull/3794#discussion_r3757705876


##########
cpp/CMakeLists.txt:
##########
@@ -337,9 +337,16 @@ if(APPLE)
     INSTALL_RPATH "@loader_path;${HOMEBREW_PREFIX}/lib;${HOMEBREW_PREFIX}/opt/openssl@3/lib"
     BUILD_WITH_INSTALL_RPATH TRUE)
 else()
+  # The version script alone is enough: it puts everything except celeborn::*
+  # and celeborn_* into the `local:` bucket. Do NOT add -Wl,--exclude-libs,ALL

Review Comment:
   celeborn_ffi_* is already subsumed by the celeborn_* glob above it in exports.map, so the effective export set is exactly celeborn::* + celeborn_* as described. Leaving the comment as is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2416] Export the C ABI from libceleborn_client.so by dropping --exclude-libs,ALL [celeborn]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3794:
URL: https://github.com/apache/celeborn/pull/3794#discussion_r3756284360


##########
cpp/CMakeLists.txt:
##########
@@ -337,9 +337,16 @@ if(APPLE)
     INSTALL_RPATH "@loader_path;${HOMEBREW_PREFIX}/lib;${HOMEBREW_PREFIX}/opt/openssl@3/lib"
     BUILD_WITH_INSTALL_RPATH TRUE)
 else()
+  # The version script alone is enough: it puts everything except celeborn::*
+  # and celeborn_* into the `local:` bucket. Do NOT add -Wl,--exclude-libs,ALL

Review Comment:
   This comment says the version script localizes everything except `celeborn::*` and `celeborn_*`, but `exports.map` also explicitly exports `celeborn_ffi_*`. Including it here will keep the rationale accurate and aligned with the actual version-script rules.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2416] Export the C ABI from libceleborn_client.so by dropping --exclude-libs,ALL [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #3794:
URL: https://github.com/apache/celeborn/pull/3794#issuecomment-5253071618

   Merged to main(v1.0.0) and branch-0.7(v0.7.0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org