You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "kirkrodrigues (via GitHub)" <gi...@apache.org> on 2023/06/05 22:08:09 UTC

[GitHub] [pinot] kirkrodrigues opened a new issue, #10849: LIKE doesn't seem to support escaping SQL wildcards

kirkrodrigues opened a new issue, #10849:
URL: https://github.com/apache/pinot/issues/10849

   A query like:
   
   `SELECT * FROM table WHERE col LIKE '%2\_2%'`
   
   gets translated to 
   
   `SELECT * FROM table WHERE REGEXP_LIKE(col, '2\\.2')`
   
   Is this the right syntax for escaping SQL wildcards?
   
   If so, this issue looks to be because [`likeToRegexpLike`](https://github.com/apache/pinot/blob/master/pinot-common/src/main/java/org/apache/pinot/common/utils/RegexpPatternConverterUtils.java#L35) doesn't handle escaped wildcards.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] atris commented on issue #10849: LIKE doesn't seem to support escaping SQL wildcards

Posted by "atris (via GitHub)" <gi...@apache.org>.
atris commented on issue #10849:
URL: https://github.com/apache/pinot/issues/10849#issuecomment-1587733818

   @Aravind-Suresh It would be good to link this issue to the PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] atris commented on issue #10849: LIKE doesn't seem to support escaping SQL wildcards

Posted by "atris (via GitHub)" <gi...@apache.org>.
atris commented on issue #10849:
URL: https://github.com/apache/pinot/issues/10849#issuecomment-1587733477

   Good catch. Reviewing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] atris closed issue #10849: LIKE doesn't seem to support escaping SQL wildcards

Posted by "atris (via GitHub)" <gi...@apache.org>.
atris closed issue #10849: LIKE doesn't seem to support escaping SQL wildcards
URL: https://github.com/apache/pinot/issues/10849


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] Aravind-Suresh commented on issue #10849: LIKE doesn't seem to support escaping SQL wildcards

Posted by "Aravind-Suresh (via GitHub)" <gi...@apache.org>.
Aravind-Suresh commented on issue #10849:
URL: https://github.com/apache/pinot/issues/10849#issuecomment-1587727080

   @Jackie-Jiang @atris I've raised a fix for this - please review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] Jackie-Jiang commented on issue #10849: LIKE doesn't seem to support escaping SQL wildcards

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #10849:
URL: https://github.com/apache/pinot/issues/10849#issuecomment-1581450218

   Good catch. I believe the problem is in `likeToRegexpLike` not handing escape properly. Seems `_` is not defined as a meta-character. cc @atris 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org