[GitHub] [incubator-brpc] chenBright commented on a diff in pull request #1814: fix ssl state exception coredump

[GitBox <gi...@apache.org>]

chenBright commented on code in PR #1814:
URL: https://github.com/apache/incubator-brpc/pull/1814#discussion_r912663242


##########
src/brpc/socket.h:
##########
@@ -747,6 +750,11 @@ friend void DereferenceSocket(Socket*);
     // Non-zero when health-checking is on.
     int _health_check_interval_s;
 
+    // Default: true,
+    // false when client SocketMap has removed socket.
+    // It can be synchronized via _versioned_ref atomic variable
+    bool _enalbe_health_check;

Review Comment:
   这样的话，还是用_stop_health_check或者_cancel_health_check合适一点吧？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org