You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/09/11 21:35:27 UTC

[GitHub] [storm] Ethanlm commented on a change in pull request #3121: STORM-3479 HB timeout configurable on a topology level

Ethanlm commented on a change in pull request #3121: STORM-3479 HB timeout configurable on a topology level
URL: https://github.com/apache/storm/pull/3121#discussion_r323254074
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/DaemonConfig.java
 ##########
 @@ -479,6 +486,12 @@
     @IsStringList
     public static final String LOGS_GROUPS = "logs.groups";
 
+    /**
+     * A topology specified timeout for determining which logs are alive.
+     */
+    @IsStringList
+    public static final String LOGS_TIMEOUT = "logs.timeout";
 
 Review comment:
   Don't introduce another config. It can be confusing. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services