You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "dutyu (via GitHub)" <gi...@apache.org> on 2023/06/21 06:43:02 UTC
[GitHub] [doris] dutyu opened a new pull request, #21070: [Fix](multi-catalog) Invalidate cache when enable auto refresh catalog.
dutyu opened a new pull request, #21070:
URL: https://github.com/apache/doris/pull/21070
## Proposed changes
The default value of `RefreshCatalogStmt.invalidCache` is false now, but the `RefreshManager.RefreshTask` does not invoke `RefreshCatalogStmt.analyze()` so it will not invalidate the cache.
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dutyu commented on pull request #21070: [Fix](multi-catalog) Invalidate cache when enable auto refresh catalog.
Posted by "dutyu (via GitHub)" <gi...@apache.org>.
dutyu commented on PR #21070:
URL: https://github.com/apache/doris/pull/21070#issuecomment-1600271310
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dutyu commented on pull request #21070: [Fix](multi-catalog) Invalidate cache when enable auto refresh catalog.
Posted by "dutyu (via GitHub)" <gi...@apache.org>.
dutyu commented on PR #21070:
URL: https://github.com/apache/doris/pull/21070#issuecomment-1600308164
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #21070: [Fix](multi-catalog) Invalidate cache when enable auto refresh catalog.
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #21070:
URL: https://github.com/apache/doris/pull/21070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Jibing-Li commented on a diff in pull request #21070: [Fix](multi-catalog) Invalidate cache when enable auto refresh catalog.
Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on code in PR #21070:
URL: https://github.com/apache/doris/pull/21070#discussion_r1236477567
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/RefreshManager.java:
##########
@@ -17,12 +17,7 @@
package org.apache.doris.catalog;
-import org.apache.doris.analysis.CreateTableStmt;
-import org.apache.doris.analysis.DropTableStmt;
-import org.apache.doris.analysis.RefreshCatalogStmt;
-import org.apache.doris.analysis.RefreshDbStmt;
-import org.apache.doris.analysis.RefreshTableStmt;
-import org.apache.doris.analysis.TableName;
+import org.apache.doris.analysis.*;
Review Comment:
This * will fail the code format check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21070: [Fix](multi-catalog) Invalidate cache when enable auto refresh catalog.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21070:
URL: https://github.com/apache/doris/pull/21070#issuecomment-1606026762
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21070: [Fix](multi-catalog) Invalidate cache when enable auto refresh catalog.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21070:
URL: https://github.com/apache/doris/pull/21070#issuecomment-1600302696
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org