You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/09 08:44:48 UTC

[GitHub] [flink] PatrickRen commented on pull request #17728: [FLINK-24832][tests][testinfrastructure] Update JUnit5 to v5.8.1

PatrickRen commented on pull request #17728:
URL: https://github.com/apache/flink/pull/17728#issuecomment-963931377


   Thanks for the patch @MartijnVisser ! This PR looks good to me generally. I checked JUnit 5's release note and [the only breaking change](https://junit.org/junit5/docs/current/release-notes/index.html#deprecations-and-breaking-changes-2) should have no effect in our project since we are not using Gradle.
   
   I'm not familiar with SQL parser so I'm not sure if there's side effect excluding `apiguardian` from calcite. @danny0405 could you take a look at this? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org