You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shiro.apache.org by "Les Hazlewood (JIRA)" <ji...@apache.org> on 2009/08/20 20:37:14 UTC

[jira] Created: (SHIRO-85) ShiroFilter entries being processed in arbitrary order

ShiroFilter entries being processed in arbitrary order
------------------------------------------------------

                 Key: SHIRO-85
                 URL: https://issues.apache.org/jira/browse/SHIRO-85
             Project: Shiro
          Issue Type: Bug
          Components: Configuration
    Affects Versions: 1.0
            Reporter: Andy Tripp
            Assignee: Les Hazlewood
            Priority: Minor
             Fix For: 0.9


Copied over from the Ki issue.  Original text:

Entries in a ShiroFilter configuration are not being processed in the order they are listed in.
If we have these lines:
   sessionManager=org.apache.shiro.web.session.DefaultWebSessionManager
   securityManager.sessionManager = $sessionManager
   securityManager.sessionDAO = $sessionDAO
...and line 3 is processed before line 2, the setSessionManager() call for the first line fails because the sessionManager is a ServletContainerSessionManager rather than a DefaultWebSessionManager.


In ReflectionBuilder.buildObjects(), instanceMap and propertyMap need
to be LinkedHashMap type, not just HashMap. With HashMap, the
properties in ShiroFilter are being processed in arbitrary order,
rather than the order listed.

See the "need more help with SSO" thread in the Shiro mailing list:
http://mail-archives.apache.org/mod_mbox/incubator-shiro-user/200908.mbox/browser 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SHIRO-85) ShiroFilter entries being processed in arbitrary order

Posted by "Les Hazlewood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHIRO-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Les Hazlewood resolved SHIRO-85.
--------------------------------

    Resolution: Fixed

Fix committed to SVN rev. 806298

> ShiroFilter entries being processed in arbitrary order
> ------------------------------------------------------
>
>                 Key: SHIRO-85
>                 URL: https://issues.apache.org/jira/browse/SHIRO-85
>             Project: Shiro
>          Issue Type: Bug
>          Components: Configuration
>    Affects Versions: 1.0
>            Reporter: Andy Tripp
>            Assignee: Les Hazlewood
>            Priority: Minor
>             Fix For: 0.9
>
>
> Copied over from the Ki issue.  Original text:
> Entries in a ShiroFilter configuration are not being processed in the order they are listed in.
> If we have these lines:
>    sessionManager=org.apache.shiro.web.session.DefaultWebSessionManager
>    securityManager.sessionManager = $sessionManager
>    securityManager.sessionDAO = $sessionDAO
> ...and line 3 is processed before line 2, the setSessionManager() call for the first line fails because the sessionManager is a ServletContainerSessionManager rather than a DefaultWebSessionManager.
> In ReflectionBuilder.buildObjects(), instanceMap and propertyMap need
> to be LinkedHashMap type, not just HashMap. With HashMap, the
> properties in ShiroFilter are being processed in arbitrary order,
> rather than the order listed.
> See the "need more help with SSO" thread in the Shiro mailing list:
> http://mail-archives.apache.org/mod_mbox/incubator-shiro-user/200908.mbox/browser 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.