You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2015/11/18 18:18:43 UTC
[GitHub] couchdb-fauxton pull request: Allow db names starting with undersc...
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/579
Allow db names starting with underscore
The JS validation unnecessarily stopped users from creating
database names with underscores. This removes that restriction.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton allow-db-names-starting-with-underscore
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/579.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #579
----
commit 7654a0cf51f5e3ff4b599da1ffd5a063320fd37f
Author: Ben Keen <be...@gmail.com>
Date: 2015-11-16T20:39:05Z
testing
commit 0b7b97d3d86c91f1097059554df586f22bb66211
Author: Ben Keen <be...@gmail.com>
Date: 2015-11-18T16:52:54Z
Allow database names to start with underscore
The JS validation unnecessarily stopped users from creating
database names with underscores. This removes that restriction.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Allow db names starting with undersc...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/579#issuecomment-159687920
Yikes! This opened up a can of worms that I didn't anticipate. Agreed on the single-source-of-truth bit, but pity the user has to wait for a request response for something like this.
Going to close because this brooks a longer investigation.
Thanks all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Allow db names starting with undersc...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/579
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Allow db names starting with undersc...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/579#issuecomment-157807715
@kxepal sounds like a good idea, +1 for a single source of truth
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Allow db names starting with undersc...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/579#issuecomment-157787469
but database names can't start with underscore, that's the reserved character, couchdb will prohibit it. Are you just trying to avoid duplicating the few that are allowed? (_users, _replicator).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Allow db names starting with undersc...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/579#issuecomment-157789528
May be remove this validation from Fauxton completely and let it make a decision based on response from CouchDB then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---