You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2013/05/01 18:24:31 UTC
Review Request: Sqoop2: Upgrade: Add framework upgrader
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10883/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
Added framework upgrade code. I know some of this can be refactored to remove the code duplication with the connector upgrade. I will look into that at a later stage.
This addresses bug SQOOP-998.
https://issues.apache.org/jira/browse/SQOOP-998
Diffs
-----
core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java 1a6d427
core/src/main/java/org/apache/sqoop/framework/FrameworkMetadataUpgrader.java PRE-CREATION
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java b2259ce
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1f88b6d
core/src/main/java/org/apache/sqoop/repository/Repository.java 7a7e884
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 556241e
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 2e5abb8
Diff: https://reviews.apache.org/r/10883/diff/
Testing
-------
Manually tested.
Thanks,
Hari Shreedharan
Re: Review Request: Sqoop2: Upgrade: Add framework upgrader
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10883/#review20135
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On May 3, 2013, 6:11 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10883/
> -----------------------------------------------------------
>
> (Updated May 3, 2013, 6:11 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Added framework upgrade code. I know some of this can be refactored to remove the code duplication with the connector upgrade. I will look into that at a later stage.
>
>
> This addresses bug SQOOP-998.
> https://issues.apache.org/jira/browse/SQOOP-998
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java 1a6d427
> core/src/main/java/org/apache/sqoop/framework/FrameworkMetadataUpgrader.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java b2259ce
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1f88b6d
> core/src/main/java/org/apache/sqoop/repository/Repository.java 7a7e884
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 556241e
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 2e5abb8
>
> Diff: https://reviews.apache.org/r/10883/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: Sqoop2: Upgrade: Add framework upgrader
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10883/
-----------------------------------------------------------
(Updated May 3, 2013, 6:11 p.m.)
Review request for Sqoop.
Changes
-------
Removing unused/redundant imports.
Description
-------
Added framework upgrade code. I know some of this can be refactored to remove the code duplication with the connector upgrade. I will look into that at a later stage.
This addresses bug SQOOP-998.
https://issues.apache.org/jira/browse/SQOOP-998
Diffs (updated)
-----
core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java 1a6d427
core/src/main/java/org/apache/sqoop/framework/FrameworkMetadataUpgrader.java PRE-CREATION
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java b2259ce
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1f88b6d
core/src/main/java/org/apache/sqoop/repository/Repository.java 7a7e884
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 556241e
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 2e5abb8
Diff: https://reviews.apache.org/r/10883/diff/
Testing
-------
Manually tested.
Thanks,
Hari Shreedharan
Re: Review Request: Sqoop2: Upgrade: Add framework upgrader
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10883/#review20124
-----------------------------------------------------------
Ship it!
Hi Hari,
thank you for stabilizing the upgrader! I do have just one nit:
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
<https://reviews.apache.org/r/10883/#comment41376>
The two new imports seems to be already covered by the ".*" import.
Jarcec
- Jarek Cecho
On May 1, 2013, 4:24 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10883/
> -----------------------------------------------------------
>
> (Updated May 1, 2013, 4:24 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Added framework upgrade code. I know some of this can be refactored to remove the code duplication with the connector upgrade. I will look into that at a later stage.
>
>
> This addresses bug SQOOP-998.
> https://issues.apache.org/jira/browse/SQOOP-998
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java 1a6d427
> core/src/main/java/org/apache/sqoop/framework/FrameworkMetadataUpgrader.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java b2259ce
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 1f88b6d
> core/src/main/java/org/apache/sqoop/repository/Repository.java 7a7e884
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 556241e
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 2e5abb8
>
> Diff: https://reviews.apache.org/r/10883/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Hari Shreedharan
>
>